revert change to Response<T, F>

Author: analogrelay

sdk/typespec/typespec_client_core/src/http/response.rs

@@ -3,18 +3,12 @@
 
 //! HTTP responses.
 
-use crate::{
-    error::HttpError,
-    http::{headers::Headers, DeserializeWith, Format, JsonFormat, StatusCode},
-};
+use crate::http::{headers::Headers, DeserializeWith, Format, JsonFormat, StatusCode};
 use bytes::Bytes;
 use futures::{Stream, StreamExt};
 use serde::de::DeserializeOwned;
 use std::{fmt, marker::PhantomData, pin::Pin};
-use typespec::{
-    error::{ErrorKind, ResultExt},
-    Error,
-};
+use typespec::error::{ErrorKind, ResultExt};
 
 #[cfg(not(target_arch = "wasm32"))]
 pub type PinnedStream = Pin<Box<dyn Stream<Item = crate::Result<Bytes>> + Send>>;
@@ -83,24 +77,6 @@ pub struct Response<T, F = JsonFormat> {
 }
 
 impl<T, F> Response<T, F> {
-    pub async fn success(self) -> crate::Result<Self> {
-        let status = self.status();
-        if status.is_success() {
-            Ok(self)
-        } else {
-            let http_error = HttpError::new(self.raw).await;
-            let error_kind = ErrorKind::http_response(
-                status,
-                http_error.error_code().map(std::borrow::ToOwned::to_owned),
-            );
-            Err(Error::full(
-                error_kind,
-                http_error,
-                format!("server returned an error response: {status}"),
-            ))
-        }
-    }
-
     /// Get the status code from the response.
     pub fn status(&self) -> StatusCode {
         self.raw.status()