Skip to content

Commit fe3b648

Browse files
committed
Incorporating review comments on unnecessary promise handling
1 parent 9ee65bd commit fe3b648

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## 0.1.7
22
Released on 2017-08-10.
3-
- Chaining the promises upto `compare` method and gracefully existing application [#88](https://github.com/Azure/openapi-diff/issues/88)
3+
- Chaining the promises upto `compare` method and gracefully exiting application [#88](https://github.com/Azure/openapi-diff/issues/88)
44

55
## 0.1.x
66
Released on 2017-07-18. All issues associated with this release can be found using this filter [Sprint-103](https://github.com/Azure/openapi-diff/issues?q=label%3ASprint-103+is%3Aclosed) [Sprint-104](https://github.com/Azure/openapi-diff/issues?utf8=%E2%9C%93&q=label%3ASprint-104%20is%3Aclosed)

lib/validators/openApiDiff.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,7 @@ class OpenApiDiff {
6060
var promise2 = self.processViaAutoRest(newSwagger, 'new');
6161

6262
return Promise.all([promise1, promise2]).then(results => {
63-
return self.processViaOpenApiDiff(results[0], results[1]).then((result, error) => {
64-
return Promise.resolve(result);
65-
});
63+
return self.processViaOpenApiDiff(results[0], results[1]);
6664
});
6765
}
6866

0 commit comments

Comments
 (0)