new feature: importing metadata for animations from gltf extras #17257
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17257/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17257/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17257/merge#BCU1XR#0 |
|
Devhost visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
qwiglydee
changed the title
|
Devhost visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
bghgary
left a comment
bghgary
left a comment
There was a problem hiding this comment.
Lgtm. I can see if I can add the tests next week.
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
Sorry for the delay on this. I'm trying to add the tests, but it seems our tests are not working properly. If this is urgent for you, I would be okay with merging this simple change as is and we can add the tests later. |
|
This pull request has been marked as stale because it has been inactive for more than 14 days. Please update to "unstale". |
|
Any update on this one ? cc @bghgary |
|
I'm fine with merging it as is for now. We can add the test later. |
|
@qwiglydee Can I move out of draft ? |
It's been over two months. I guess it should be rebased on recent codebase. |
|
Devhost visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
4 participants
Not tested, because testing relies on assets