Open
Conversation
…nto BNGSPLY # Conflicts: # Apps/Playground/Win32/App.cpp # CMakeLists.txt
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Babylon.js dependencies and native/shader plumbing to support Gaussian Splatting (including SH data) in the Babylon Native Playground and associated shader/toolchain paths.
Changes:
- Bumps Babylon.js packages to
8.53.0and updates native dependencies (JsRuntimeHost + SPIRV-Cross source/tag). - Extends shader sampler Y-flip patching to cover
texelFetchand expands supported texture formats (RGBA32U). - Adds
TextDecoderpolyfill wiring (linking, initialization, install) and introduces a new Playground image-based test case with a reference image.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| Plugins/ShaderCompiler/Source/ShaderCompilerCommon.cpp | Adds texelFetch Y-flip macro in the OpenGL sampler flip patching block. |
| Plugins/NativeEngine/Source/NativeEngine.cpp | Allows RGBA32U images through PrepareImage format assertions. |
| Install/Install.cmake | Installs the TextDecoder polyfill when the target exists. |
| CMakeLists.txt | Updates FetchContent pins; switches SPIRV-Cross repository URL/tag. |
| Apps/package.json | Updates Babylon.js package versions to ^8.53.0. |
| Apps/Playground/Shared/AppContext.cpp | Includes and initializes the TextDecoder polyfill. |
| Apps/Playground/Scripts/config.json | Adds a new Gaussian Splatting SH Playground test entry (with OpenGL exclusion note). |
| Apps/Playground/ReferenceImages/gsplat-compressedply-sh.png | Adds the reference image for the new test. |
| Apps/Playground/CMakeLists.txt | Links TextDecoder into the Playground app. |
| Apps/Playground/Android/BabylonNative/CMakeLists.txt | Links TextDecoder into the Android JNI target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.