Merge pull request #19 from jkyberneees/drop-low-implementation

Drop low implementation

Author: jkyberneees

.travis.yml

@@ -0,0 +1,5 @@
+language: node_js
+node_js:
+  - "10"
+
+install: npm install

README.md

@@ -156,39 +156,6 @@ const { router, server } = cero({
 If no server is provided by configuration, the standard Node.js [http.Server](https://nodejs.org/api/http.html#http_class_http_server) implementation is used.  
 Because this server offers the best balance between Node.js ecosystem compatibility and performance, we highly recommend it for most use cases.
 
-### Low Server
-`low` is a tiny Node.js friendly wrapper around the great [uWebSockets.js](https://github.com/uNetworking/uWebSockets.js) HTTP server. I/O throughput is 
-maximized at the cost of API compatibility.
-> As far as for Node.js, `uWebSockets.js` brings the best I/O performance in terms of HTTP support.
-
-#### Install dependencies
-```
-npm i uNetworking/uWebSockets.js#v15.11.0
-```
-#### Example usage
-```js
-const low = require('0http/lib/server/low')
-const cero = require('0http')
-
-const { router, server } = cero({
-  server: low()
-})
-
-router.get('/hi', (req, res) => {
-  res.end('Hello World!')
-})
-
-server.listen(3000, (socket) => {
-  if (socket) {
-    console.log('HTTP server ready!')
-  }
-})
-
-
-// ...
-server.close()
-```
-
 ## Benchmarks (30/12/2019)
 **Node version**: v12.14.0  
 **Laptop**: MacBook Pro 2019, 2,4 GHz Intel Core i9, 32 GB 2400 MHz DDR4  
@@ -199,10 +166,6 @@ wrk -t8 -c40 -d5s http://127.0.0.1:3000/hi
 ```
 
 ### 1 route registered
-- **0http (find-my-way + low)**  
-  `Requests/sec:  135436.99`
-- 0http (sequential + low)  
-  `Requests/sec:  134281.32`
 - 0http (sequential)   
   `Requests/sec:  88438.69`
 - 0http (find-my-way)   
@@ -226,4 +189,8 @@ You can support the maintenance of this project:
 - XRP Crypto Coin: `rarQgNuiqF9gFLLwd5fdku4jYa9EXpiyCp`
 - TRON Crypto Coin: `TJ5Bbf9v4kpptnRsePXYDvnYcYrS5Tyxus`
 - BITCOIN Crypto Coin: `bc1qcrr58venyh54ztvkqym39p9rhnxg4308t0802f`
-- Ethereum Crypto Coin: `0xD73c8E63a83eBD8Df3fB3d0090f1fe7a1eEB980B`
+- Ethereum Crypto Coin: `0xD73c8E63a83eBD8Df3fB3d0090f1fe7a1eEB980B`
+
+## Breaking Changes:
+### 3.x
+- Low HTTP server implementation was moved to: https://github.com/jkyberneees/low-http-server

lib/server/low.js

@@ -30,11 +30,10 @@
   "devDependencies": {
     "chai": "^4.2.0",
     "find-my-way": "^3.0.1",
-    "mocha": "^7.2.0",
+    "mocha": "^8.1.3",
     "nyc": "^15.1.0",
-    "standard": "^14.3.4",
     "supertest": "^4.0.2",
-    "uWebSockets.js": "github:uNetworking/uWebSockets.js#v17.5.0"
+    "body-parser": "^1.19.0"
   },
   "files": [
     "LICENSE",
@@ -43,7 +42,7 @@
     "lib/"
   ],
   "dependencies": {
-    "lru-cache": "^5.1.1",
+    "lru-cache": "^6.0.0",
     "trouter": "^3.1.0"
   }
 }

lib/utils/string.js

@@ -3,16 +3,17 @@ const expect = require('chai').expect
 const request = require('supertest')
 const path = require('path')
 const { createReadStream } = require('fs')
+const bodyParser = require('body-parser')
 
 describe('0http Web Framework - Smoke', () => {
   const baseUrl = 'http://localhost:' + process.env.PORT
 
   const { router, server } = require('../index')({
-    server: require('../lib/server/low')(),
     router: require('../lib/router/sequential')()
   })
 
   it('should successfully register service routes', (done) => {
+    router.use(bodyParser.json())
     router.use((req, res, next) => next())
     router.use('/', (req, res, next) => next())
 
@@ -32,7 +33,7 @@ describe('0http Web Framework - Smoke', () => {
     })
 
     router.post('/echo', (req, res) => {
-      res.end(req.body)
+      res.end(JSON.stringify(req.body))
     })
 
     router.get('/qs', (req, res) => {
@@ -84,10 +85,8 @@ describe('0http Web Framework - Smoke', () => {
       res.end(`${req.stepUrl} - ${req.url}`)
     })
 
-    server.start(~~process.env.PORT, serverSocket => {
-      if (serverSocket) {
-        done()
-      }
+    server.listen(~~process.env.PORT, () => {
+      done()
     })
   })