Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typing_extensions instead of inspect and typing to correctly backport modern functionality #14

Open
BeatsuDev opened this issue Sep 2, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BeatsuDev
Copy link
Owner

gqlrequests/query_creator.py suffers from whacky code that imports certain properties based on the current Python version. This makes mypy complain too, and per now these type errors are just ignored. The correct solution would be to use the typing_extensions module instead, which backports common type-related functions from inspect and typing.

https://typing-extensions.readthedocs.io/en/latest/

@BeatsuDev BeatsuDev added enhancement New feature or request good first issue Good for newcomers labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant