Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Group all unit tests that simply check if properties are "gettable" #47

Open
BeatsuDev opened this issue Nov 19, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers low priority This issue will probably not be looked into for a while

Comments

@BeatsuDev
Copy link
Owner

Which part to refactor

Group all tests that check for hardcoded values in the demo account to a single test.

Why this should be refactored

Most of the tests now don't really test any difficult logic. Even if all these tests that simply check if a property is "gettable" it would be very easy to locate the problem if the test fails because there is basically no logic in them.

What breaking changes does this have for the end-user

None

@BeatsuDev BeatsuDev added enhancement New feature or request good first issue Good for newcomers low priority This issue will probably not be looked into for a while labels Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers low priority This issue will probably not be looked into for a while
Projects
None yet
Development

No branches or pull requests

1 participant