Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] price_info for other than today/tomorrow #55

Closed
MazrimT opened this issue Jan 5, 2025 · 2 comments · Fixed by #56
Closed

[FEATURE] price_info for other than today/tomorrow #55

MazrimT opened this issue Jan 5, 2025 · 2 comments · Fixed by #56
Labels
enhancement New feature or request

Comments

@MazrimT
Copy link

MazrimT commented Jan 5, 2025

Is your feature request related to a problem? Please describe.

price_info for a specific (historical) date or timeframe

Describe the solution you'd like

You have two great functions set up
current_subscription.price_info.today
current_subscription.price_info.tomorrow

But what if I want to get the price info for a specific historical date? would there be a way to add a way to do that?

Describe alternatives you've considered

Additional context

Reason is to get the historical data after the fact.

@MazrimT MazrimT added the enhancement New feature or request label Jan 5, 2025
@MazrimT MazrimT changed the title [FEATURE] [FEATURE] price_info for other than today/tomorrow Jan 5, 2025
@BeatsuDev
Copy link
Owner

BeatsuDev commented Jan 6, 2025

Thank you for the issue! I'll add the current_subscription.price_info.range() function as per the tibber API documentation.

@BeatsuDev BeatsuDev linked a pull request Jan 6, 2025 that will close this issue
@BeatsuDev
Copy link
Owner

BeatsuDev commented Jan 6, 2025

@MazrimT It's now possible to get historical price data with the PriceInfo.fetch_range() method. I added an example to the README and published the changes to pypi in version 0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants