Context
In commit 1eb0832, we added #![allow(dead_code)] to five modules to pass cargo clippy -D warnings in CI. These modules contain code that is not yet wired into the CLI's command dispatch.
Files with #![allow(dead_code)]
| File |
Contents |
Reason |
src/commands/api.rs |
.verilib file CRUD (get/set/list/batch) |
API subcommand not exposed in cli.rs |
src/commands/deploy.rs |
Repository deployment flow |
Deploy command not exposed in cli.rs |
src/commands/types.rs |
DeployNode, DeployResponse, DeployData structs |
Used only by deploy.rs |
src/download/client.rs |
download_repo, wait_for_atomization |
Download/pull flow not exposed |
src/download/types.rs |
TreeNode, Snippet, DownloadResponse, etc. |
Used only by download/client.rs |
Action items
For each file, decide one of:
- Wire it in: expose the command in
cli.rs and main.rs, remove the suppression
- Remove it: if the code is obsolete or superseded, delete the file and remove the
mod declaration
- Keep suppressed: if it's actively being developed but not ready yet, leave as-is
Once all files are resolved, this issue can be closed.
Context
In commit 1eb0832, we added
#![allow(dead_code)]to five modules to passcargo clippy -D warningsin CI. These modules contain code that is not yet wired into the CLI's command dispatch.Files with
#![allow(dead_code)]src/commands/api.rs.verilibfile CRUD (get/set/list/batch)cli.rssrc/commands/deploy.rscli.rssrc/commands/types.rsDeployNode,DeployResponse,DeployDatastructssrc/download/client.rsdownload_repo,wait_for_atomizationsrc/download/types.rsTreeNode,Snippet,DownloadResponse, etc.Action items
For each file, decide one of:
cli.rsandmain.rs, remove the suppressionmoddeclarationOnce all files are resolved, this issue can be closed.