Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Excluding folders based on release type or replacements on .pkgmeta files #165

Open
emmericp opened this issue May 5, 2024 · 3 comments

Comments

@emmericp
Copy link

emmericp commented May 5, 2024

I'm in the process of adding some large-ish test data over multiple files to an AddOn that I would like to only include in alpha builds.

I'm currently just putting #@alpha@ tags into the toc file to prevent the files from being loaded, but I would like to exclude them fully just to keep the package a bit smaller.

Maybe it would be a good idea to have some replacements on the .pkgmeta file that gets applied prior to the .pkgmeta being evaluated?
For example:

ignore:
  - Foo/Bar
#@alpha@
  - Foo/Testdata/
#@end-alpha@

Which would comment it out in non-alpha builds. Could probably be the same code as toc replacements because both use # for comments.

@Meorawr
Copy link
Contributor

Meorawr commented May 5, 2024

Personally I've no horse in this race, but an alternative solution that'll work for you today is to use the -m pkgmeta.yaml flag to specify a different .pkgmeta with a different set of ignores for your alpha builds.

Only downside is I believe there's no generic include: other-pkgmeta.yaml functionality, so you'll need to effectively duplicate the contents in full into this secondary file.

@nebularg
Copy link
Member

nebularg commented May 6, 2024

Yea, @Meorawr beat me to it but I would just recommend creating a new pkgmeta that is used for alpha builds as that is already the recommended practice for dealing with builds of different versions.

@emmericp
Copy link
Author

Only downside is I believe there's no generic include: other-pkgmeta.yaml functionality

Also, I need to basically re-invent the check for which version is being built

emmericp added a commit to emmericp/DBM-Vanilla that referenced this issue May 11, 2024
This seems to be the only way to fully exclude a whole addon from
release builds.

BigWigsMods/packager#165
emmericp added a commit to DeadlyBossMods/DBM-Vanilla that referenced this issue May 11, 2024
This seems to be the only way to fully exclude a whole addon from
release builds.

BigWigsMods/packager#165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants