Refactor check_manually to improve readability

Author: Paiusco

check_manually.sh

@@ -2,78 +2,78 @@
 
 SOURCE_FILE=README.md
 
-LINKS=$(grep -oP "http.*" "$SOURCE_FILE" \
-| sed -e "s|)$||" -e "s|) .*||" \
-| grep -v img.shields.io \
-| grep -v travis-ci.org)
+function check_deprecated_repos() {
+  GITHUB_LINKS=$(grep -o "https://github.com/.*" "$SOURCE_FILE" \
+    | sed 's|).*||')
 
-mapfile -t LINKS <<< "$LINKS"
+  mapfile -t GITHUB_LINKS <<< "$GITHUB_LINKS"
 
-for link in "${LINKS[@]}"
-do
-    echo "Testing $link"
-    STATUS_CODE="$(curl -LI "$link" -o /dev/null -w '%{http_code}\n' -s)"
-    if [[ "$STATUS_CODE" != "200" ]]
-    then
-        FALSE_LINKS+=("$link")
+  for link in "${GITHUB_LINKS[@]}"; do
+    echo "Checking if repo $link is not deprecated"
+    DEPRECATED=$(curl "$link" -s | awk -v depr_repo_res='false' \
+      '/This repository has been archived by the owner. It is now read-only./ \
+        {depr_repo_res="true"} END {print depr_repo_res}')
+    if [[ "$DEPRECATED" == "true" ]]; then
+      deprecated_repos+=("$link")
     fi
-done
+  done
 
-FDROID_LINKS=$(grep -oP "https://f-droid.*" "$SOURCE_FILE" \
-| sed "s|)].*||" \
-| grep -v "https://f-droid.org/)")
+  if [ -n "${deprecated_repos[*]}" ]; then
+    depr_repo_res=1
+  fi
+}
 
-mapfile -t FDROID_LINKS <<< "$FDROID_LINKS"
+function check_false_links() {
+  LINKS=$(grep -oP "http.*" "$SOURCE_FILE" \
+  | sed -e "s|)$||" -e "s|).*||" \
+  | grep -v img.shields.io \
+  | grep -v travis-ci.org)
 
-for link in "${FDROID_LINKS[@]}"
-do
-    echo "Testing $link"
-    STATUS_CODE="$(curl -LI "$link" -o /dev/null -w '%{http_code}\n' -s)"
-    if [[ "$STATUS_CODE" != "200" ]]
-    then
-        FALSE_LINKS+=("$link")
-    fi
-done
+  mapfile -t LINKS <<< "$LINKS"
 
-if [ -n "${FALSE_LINKS[*]}" ]
-then
-    clear
-    echo "Some links weren't reachable."
-    for link in "${FALSE_LINKS[@]}"
-    do
-        echo "$link"
-    done
-    exit 1
-else
-    echo "No false link was found"
-fi
+  for link in "${LINKS[@]}"
+  do
+      echo "Checking $link"
+      STATUS_CODE="$(curl -LI "$link" -o /dev/null -w '%{http_code}\n' -s)"
+      if [[ "$STATUS_CODE" != "200" ]]
+      then
+          bad_links+=("$link")
+      fi
+  done
 
-GITHUB_LINKS=$(grep -o "https://github.com/.*" README.md \
-    | sed 's|).*||')
+  if [ -n "${bad_links[*]}" ]
+  then
+      link_res=1
+  fi
+}
 
-mapfile -t GITHUB_LINKS <<< "$GITHUB_LINKS"
+function check_links() {
+  local depr_repo_res=0
+  local deprecated_repos
+  check_deprecated_repos
 
-for link in "${GITHUB_LINKS[@]}"
-do
-    echo "Checking if repo $link is not deprecated"
-    DEPRECATED=$(curl "$link" -s | awk -v result='false' \
-        '/This repository has been archived by the owner. It is now read-only./ \
-	    {result="true"} END {print result}')
-    if [[ "$DEPRECATED" == "true" ]]
-    then
-        GITHUB_DEPRECATED_LINKS+=("$link")
-    fi
-done
+  local link_res=0
+  local bad_links
+  check_false_links
+
+  clear
+  if [[ link_res -eq "1" ]]; then
+    echo "Unreachable links were found:"
+    for link in "${bad_links[@]}"; do
+      echo "$link"
+    done
+  fi
 
-if [ -n "${GITHUB_DEPRECATED_LINKS[*]}" ]
-then
-    clear
-    echo "Deprecated Github Repos were found:"
-    for link in "${GITHUB_DEPRECATED_LINKS[@]}"
-    do
-        echo "$link"
+  if [[ depr_repo_res -eq "1" ]]; then
+    echo "Deprecated repo were found:"
+    for link in "${deprecated_repos[@]}"; do
+      echo "$link"
     done
-    exit 1
-else
-    echo "No deprecated repo was found"
-fi
+  fi
+
+  if [[ depr_repo_res -eq 0 && link_res -eq 0 ]]; then
+    echo "All links are validated!"
+  fi
+}
+
+check_links