C2C-3 Review and fix Rachio Integration (SmartThingsCommunity#3361)

Update default value for watering valve to be off
Update calculation of rainDelay to prevent negative days

Author: marstorp

devicetypes/rachio/rachio-iro2-controller.src/rachio-iro2-controller.groovy

@@ -78,10 +78,10 @@ metadata {
     tiles (scale: 2){
         multiAttributeTile(name: "valveTile", type: "generic", width: 6, height: 4) {
             tileAttribute("device.watering", key: "PRIMARY_CONTROL" ) {
-                attributeState "on", label: 'Watering', action: "close", icon: "st.valves.water.open", backgroundColor: "#00a0dc", nextState: "off"
                 attributeState "off", label: 'Off', action: "runAllZones", icon: "st.valves.water.closed", backgroundColor: "#ffffff", nextState:"on"
                 attributeState "offline", label: 'Offline', icon: "st.valves.water.closed", backgroundColor: "#cccccc"
                 attributeState "standby", label: 'Standby Mode', icon: "st.valves.water.closed", backgroundColor: "#cccccc"
+                attributeState "on", label: 'Watering', action: "close", icon: "st.valves.water.open", backgroundColor: "#00a0dc", nextState: "off"
             }
             tileAttribute("device.curZoneRunStatus", key: "SECONDARY_CONTROL") {
                 attributeState("default", label:'${currentValue}')

devicetypes/rachio/rachio-iro2-zone.src/rachio-iro2-zone.groovy

@@ -86,11 +86,11 @@ metadata {
     tiles (scale: 2){
         multiAttributeTile(name: "valveTile", type: "generic", width: 6, height: 4) {
             tileAttribute("device.watering", key: "PRIMARY_CONTROL" ) {
-                attributeState "on", label: 'Watering', action: "close", icon: "st.valves.water.open", backgroundColor: "#00a0dc", nextState: "updating"
                 attributeState "off", label: 'Off', action: "open", icon: "st.valves.water.closed", backgroundColor: "#ffffff", nextState:"updating"
                 attributeState "offline", label: 'Offline', icon: "st.valves.water.closed", backgroundColor: "#cccccc"
                 attributeState "disabled", label: 'Disabled', icon: "st.valves.water.closed", backgroundColor: "#cccccc"
                 attributeState "standby", label: 'Standby Mode', icon: "st.valves.water.closed", backgroundColor: "#cccccc"
+                attributeState "on", label: 'Watering', action: "close", icon: "st.valves.water.open", backgroundColor: "#00a0dc", nextState: "updating"
                 attributeState "updating", label:"Working"
             }
             tileAttribute("device.zoneRunStatus", key: "SECONDARY_CONTROL") {

smartapps/rachio/rachio-connect.src/rachio-connect.groovy

@@ -1281,9 +1281,12 @@ def getCurrentRainDelay(res) {
     //log.debug("getCurrentRainDelay($devId)...")
     // convert to configured rain delay to days.
     //def ret =  (res?.rainDelayExpirationDate || res?.rainDelayStartDate) ? (res?.rainDelayExpirationDate - res?.rainDelayStartDate)/(26*60*60*1000) : 0
+    def value =  0
     def rainDelayStartDate = res?.rainDelayStartDate ?: (new Date().getTime())
-    def ret =  (res?.rainDelayExpirationDate) ? (res?.rainDelayExpirationDate - rainDelayStartDate)/(26*60*60*1000) : 0
-    def value = (long) Math.floor(ret + 0.5d)
+    if(res?.rainDelayExpirationDate && (rainDelayStartDate < res.rainDelayExpirationDate)) {
+        value = (res.rainDelayExpirationDate - rainDelayStartDate)/(26*60*60*1000)
+        value = (long) Math.floor(value + 0.5d)
+    }
     return value
 }