Name your stream

Author: BrennanConroy

Hubs/StreamHub.cs

@@ -23,7 +23,8 @@ public ChannelReader<string> WatchStream(string streamName)
     {
         // TODO:
         // Allow client to stop watching a stream, or is that automatic if they cancel on the client (double check this)
-
+        // There can be multiple consumers, so we'll need to do something about that so they all get the frames instead of getting (1 / # clients) frames
+ 
         var stream = _streamManager.GetStream(streamName);
         return stream;
     }
@@ -36,7 +37,6 @@ public async Task StartStream(string streamName, ChannelReader<string> streamCon
         var channel = Channel.CreateBounded<string>(options: new BoundedChannelOptions(2) {
             FullMode = BoundedChannelFullMode.DropOldest
         });
-        //var channel = Channel.CreateUnbounded<string>();
 
         if (!_streamManager.AddStream(streamName, channel))
         {

Pages/Index.cshtml

@@ -11,7 +11,9 @@ Available streams:
     </ul>
 </div>
 
+Stream name: <input type="textbox" id="streamName" value="" />
 <input type="button" id="startStream" value="Start streaming" />
+<input type="button" id="stopStream" value="Stop streaming" disabled />
 
 <pre id="myPre"></pre>
 <canvas id="myCanvas"></canvas>
@@ -58,8 +60,20 @@ async function startAsync() {
     }
 
     const startStreamButton = document.getElementById('startStream');
+    const stopStreamButton = document.getElementById('stopStream');
+    stopStreamButton.onclick = function () {
+        stopStreamButton.setAttribute("disabled", "disabled");
+        startStreamButton.removeAttribute("disabled");
+        if (isStreaming === true) {
+            subject.complete();
+            camera.stop();
+            isStreaming = false;
+        }
+    }
     startStreamButton.onclick = async function () {
         startStreamButton.setAttribute("disabled", "disabled");
+        stopStreamButton.removeAttribute("disabled");
+        let streamName = document.getElementById("streamName").value;
         const asciiCanvas = document.getElementById("myPre");
 
         subject = new signalR.Subject();
@@ -82,14 +96,18 @@ async function startAsync() {
             },
 
             onSuccess: function() {
+                isStreaming = true;
             },
 
             onError: function(error) {
                 console.log(error);
             }
         });
 
-        await connection.send("StartStream", "Some name", subject);
+        if (streamName === "") {
+            streamName = "random name " + Math.random() * 2;
+        }
+        await connection.send("StartStream", streamName, subject);
     }
 }
 

Startup.cs

@@ -64,8 +64,8 @@ public void Configure(IApplicationBuilder app, IHostingEnvironment env)
             {
                 route.MapHub<StreamHub>("/stream", o =>
                 {
-                    o.TransportMaxBufferSize = 1000000;
-                    o.ApplicationMaxBufferSize = 1000000;
+                    //o.TransportMaxBufferSize = 1000000;
+                    //o.ApplicationMaxBufferSize = 1000000;
                 });
             });