Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constraints.json #15

Open
DE0CH opened this issue Aug 25, 2022 · 3 comments
Open

Remove constraints.json #15

DE0CH opened this issue Aug 25, 2022 · 3 comments
Labels
bad form Ugly code that doesn't need to be fixed because it doesn't affect anything, but it looks ugly!! refactor Refactoring that need to be coordinated

Comments

@DE0CH
Copy link
Member

DE0CH commented Aug 25, 2022

This file is redundant now since the information is in statement.json. It should be removed, though it doesn't matter too much if it is not.

@DE0CH DE0CH added refactor Refactoring that need to be coordinated bad form Ugly code that doesn't need to be fixed because it doesn't affect anything, but it looks ugly!! labels Aug 25, 2022
@Daniel5055
Copy link
Contributor

Are you referring to the old constrains file or do you mean constraints? If so then yeah I can change the executioner to read from statements.json instead once I handle some of these other issues first.

@DE0CH DE0CH changed the title Remove constrains.json Remove constraints.json Aug 25, 2022
@DE0CH
Copy link
Member Author

DE0CH commented Aug 25, 2022

Yeah look at me, misspelt constraints again... lol. Yes I mean constraints.json in the problem folder. Please don't worry about this for now. There are checks to ensure the constraints are consistent and there is no negative effect except for some bad form if we leave it like this.

@Daniel5055
Copy link
Contributor

@DE0CH I've recently just made the switch to reading from the statement.json file. So we can start to migrate to that then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad form Ugly code that doesn't need to be fixed because it doesn't affect anything, but it looks ugly!! refactor Refactoring that need to be coordinated
Projects
None yet
Development

No branches or pull requests

2 participants