[SofaBaseLinearSolver] Remove the IsRequired flag in CGLinearSolver

damienmarchal · damienmarchal · commit 455b0fce9a84 · 2021-11-22T14:30:03.000+01:00
PR 2419 restores the correct behavior of CGLinearSolver regarding the call-super-init sofa-framework#2419 But as some of its data are tagged as Required, this rise en error message when the value is not set by the user. I'm not sure it is wise to use the required flag when data provides meaningful and usable default values. So I recommand removing it.
diff --git a/SofaKernel/modules/SofaBaseLinearSolver/src/SofaBaseLinearSolver/CGLinearSolver.inl b/SofaKernel/modules/SofaBaseLinearSolver/src/SofaBaseLinearSolver/CGLinearSolver.inl
@@ -40,9 +40,6 @@ CGLinearSolver<TMatrix,TVector>::CGLinearSolver()
     , d_graph( initData(&d_graph,"graph","Graph of residuals at each iteration") )
 {
     d_graph.setWidget("graph");
-    d_maxIter.setRequired(true);
-    d_tolerance.setRequired(true);
-    d_smallDenominatorThreshold.setRequired(true);
 }
 
 /// Initialization function checking input Data

Original file line number	Diff line number	Diff line change
`@@ -40,9 +40,6 @@ CGLinearSolver<TMatrix,TVector>::CGLinearSolver()`
`40`	`40`	`, d_graph( initData(&d_graph,"graph","Graph of residuals at each iteration") )`
`41`	`41`	`{`
`42`	`42`	`d_graph.setWidget("graph");`
`43`		`- d_maxIter.setRequired(true);`
`44`		`- d_tolerance.setRequired(true);`
`45`		`- d_smallDenominatorThreshold.setRequired(true);`
`46`	`43`	`}`
`47`	`44`
`48`	`45`	`/// Initialization function checking input Data`