Seeing many animated blocks causes severe performance drop

[Thinkseal]

Bug Description

on macOS when looking at areas with lots of animated textures fps can drop as much as 50%
this was discussed on discord https://discord.com/channels/602796788608401408/1467024196289695826
this issue is much worse in vanilla

Reproduction Steps

1. get a mac with an intel gpu or m1 gpu
2. look at the ocean
3. notice that the fps lowers noticeably even when the game tick rate is frozen (making textures no longer visually animated)

Log File

n/a

Crash Report

n/a

[douira]

Is there a corresponding ticket for this vanilla issue on Mojira?

[douira]

profiles from a user in the thread:

• looking at the kelp: https://spark.lucko.me/cRjzJR5E3f
• looking away: https://spark.lucko.me/obS84eOetQ

For some reason, the profiler picks up the sky being particularly slow to render when looking at a lot of kelp.

[jellysquid3]

OpenGL commands are executed asynchronously and may block at any time if the command buffer on the driver is unable to accept more work. It's probably not the case that the sky itself is taking longer to render, it's just the next thing to be drawn.

[douira]

• It would be useful if somebody not on macOS could check whether this issue happens for them too. Preferably the comparison scene should have a similar number of sections.
• It should also be checked if freezing the game substantially improves performance.
• It should be checked if using a texture pack that removes animations (I found this but am unsure of its compatibility) without tick freeze substantially improves performance.

[douira]

Vogonpoetry and the author of this issue have confirmed that it does in fact also happen on other systems, such as Windows with Intel HD or Nvidia GPUs.