Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is Microsoft.Windows.Compatibility dependency required for .NET 8.0 WPF projects? #902

Closed
madorjan opened this issue Jul 10, 2024 · 2 comments · Fixed by #891
Closed

Is Microsoft.Windows.Compatibility dependency required for .NET 8.0 WPF projects? #902

madorjan opened this issue Jul 10, 2024 · 2 comments · Fixed by #891
Assignees
@vb2ae

Comments

@madorjan
Copy link

Due to a vulnerability in the transitive dependency System.Formats.Asn1 we found out that Caliburn.Micro references Microsoft.Windows.Compatibility in our .NET8 project. Is this still required?

.NET5 and .NET6 targets don't require that dependency anymore, as can be seen here:
https://github.com/Caliburn-Micro/Caliburn.Micro/blob/master/src/Caliburn.Micro.Platform/Caliburn.Micro.Platform.csproj#L55
@vb2ae
Copy link
Member

vb2ae commented Jul 11, 2024

Thanks for reporting this will fix

@vb2ae vb2ae self-assigned this Jul 11, 2024
@MikiraSora
Copy link

Is it fixed and release new? Because Microsoft.Windows.Compatibility contains System.Data.SqlClient and the later not support in .Net 8

@vb2ae vb2ae linked a pull request Oct 25, 2024 that will close this issue
Create dotnet.yml #891
Merged
@vb2ae vb2ae closed this as completed in #891 Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vb2ae vb2ae

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create dotnet.yml Caliburn-Micro/Caliburn.Micro
3 participants
@vb2ae @MikiraSora @madorjan