From d70424634eaf55b0233992d9889f82a9b6b5f30a Mon Sep 17 00:00:00 2001 From: Mirza-Samad-Ahmed-Baig Date: Sat, 2 Aug 2025 19:29:34 +0500 Subject: [PATCH] fix: add missing quotes around column names in relation conditions The getRelationCondition method was not properly quoting column names in SQL conditions, which could cause issues with column names that contain spaces or special characters. This commit adds double quotes around column names to match the existing pattern used for model names. --- wren-ui/src/apollo/server/mdl/mdlBuilder.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wren-ui/src/apollo/server/mdl/mdlBuilder.ts b/wren-ui/src/apollo/server/mdl/mdlBuilder.ts index d6d6f4a57f..4ec56746f7 100644 --- a/wren-ui/src/apollo/server/mdl/mdlBuilder.ts +++ b/wren-ui/src/apollo/server/mdl/mdlBuilder.ts @@ -430,7 +430,7 @@ export class MDLBuilder implements IMDLBuilder { //TODO phase2: implement the expression for relation condition const { fromColumnName, toColumnName, fromModelName, toModelName } = relation; - return `"${fromModelName}".${fromColumnName} = "${toModelName}".${toColumnName}`; + return `"${fromModelName}"."${fromColumnName}" = "${toModelName}"."${toColumnName}"`; } private buildTableReference(model: Model): TableReference | null {