You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The test mpool_nonce_fix_auto_unblocks_pending was removed from the calibnet mpool integration test suite in #7229 because it was no longer needed as a pre-run step. However, it should be preserved and run as a regression test on main branch commits to ensure that the underlying mpool nonce-fix bug does not regress.
Wire it up to the CI pipeline so it runs automatically on commits to the main branch (e.g., in a nightly/regression workflow or the existing calibnet CI job restricted to main).
Ensure the test is clearly labelled/documented as a regression test for the mpool nonce-fix behaviour.
Rationale
The test validates that the mpool's automatic nonce-fix correctly unblocks pending messages. Dropping it entirely risks silent regression of the fix it was originally written to guard against.
Summary
The test
mpool_nonce_fix_auto_unblocks_pendingwas removed from the calibnet mpool integration test suite in #7229 because it was no longer needed as a pre-run step. However, it should be preserved and run as a regression test onmainbranch commits to ensure that the underlying mpool nonce-fix bug does not regress.Required Changes
mpool_nonce_fix_auto_unblocks_pendingtest logic fromsrc/dev/subcommands/tests_cmd/calibnet/mpool.rs(see fix(ci): allow concurrent wallet tests on CI #7229).mainbranch (e.g., in a nightly/regression workflow or the existing calibnet CI job restricted tomain).Rationale
The test validates that the mpool's automatic nonce-fix correctly unblocks pending messages. Dropping it entirely risks silent regression of the fix it was originally written to guard against.
References
/cc @sudo-shashank