Skip to content

Commit 79ca7d4

Browse files
committedDec 9, 2020
fix delete for everyone action handler.
1 parent 25ee291 commit 79ca7d4

File tree

2 files changed

+25
-14
lines changed

2 files changed

+25
-14
lines changed
 

‎live-stream/src/js/components/conversation.js

+13-8
Original file line numberDiff line numberDiff line change
@@ -1759,7 +1759,7 @@ class Conversation {
17591759
let msgContainer = this.utility.createElement("div", msgContainerAttributes, null, msgBubbleEle);
17601760

17611761
// Create message more options
1762-
let moreOptionAttributes = [{"class":"ch-msg-more-option ch-right"},{"title":LANGUAGE_PHRASES.MORE_OPTIONS}];
1762+
let moreOptionAttributes = [{"id":"ch_message_more_option_" + message.id},{"class":"ch-msg-more-option ch-right"},{"title":LANGUAGE_PHRASES.MORE_OPTIONS}];
17631763
let moreOption = this.utility.createElement("i", moreOptionAttributes, "more_vert", msgBubbleEle);
17641764
moreOption.classList.add("material-icons");
17651765

@@ -1772,7 +1772,7 @@ class Conversation {
17721772

17731773
// Create add reaction div.
17741774
if (this.reactionsSetting.enable && message.ownerId != this.liveStream.userId && !message.isDeleted) {
1775-
let addReactionEleAttributes = [{"class":"ch-add-reaction-option"},{"title":LANGUAGE_PHRASES.REACT_TO_THIS_MESSAGE}];
1775+
let addReactionEleAttributes = [{"id":"ch_message_insert_emoticon_" + message.id},{"class":"ch-add-reaction-option"},{"title":LANGUAGE_PHRASES.REACT_TO_THIS_MESSAGE}];
17761776
let addReactionEle = this.utility.createElement("i", addReactionEleAttributes, "insert_emoticon", msgBubbleEle);
17771777
addReactionEle.classList.add("material-icons");
17781778

@@ -1844,11 +1844,10 @@ class Conversation {
18441844
});
18451845
}
18461846

1847-
// Update listener of deleted message
1848-
let targetMessage = document.getElementById(messageId)
1849-
if (targetMessage) {
1850-
let deletedMsgOptionBtn = targetMessage.lastChild;
1851-
deletedMsgOptionBtn.addEventListener("click", data => {
1847+
// Update more option listener of deleted message
1848+
let moreOptionBtn = document.getElementById("ch_message_more_option_" + messageId);
1849+
if (moreOptionBtn) {
1850+
moreOptionBtn.addEventListener("click", data => {
18521851
// Remove delete for everyone option
18531852
let deleteForEveryoneBtn = document.getElementById("ch_msg_delete_for_everyone");
18541853
if (deleteForEveryoneBtn) {
@@ -1861,7 +1860,13 @@ class Conversation {
18611860
deleteStartThread.remove();
18621861
}
18631862
});
1864-
}
1863+
}
1864+
1865+
// Update insert emoticon listener of deleted message
1866+
let insertEmoticonBtn = document.getElementById("ch_message_insert_emoticon_" + messageId);
1867+
if (insertEmoticonBtn) {
1868+
insertEmoticonBtn.remove();
1869+
}
18651870
}
18661871

18671872
handleAddReaction(data) {

‎live-stream/src/js/components/threads.js

+12-6
Original file line numberDiff line numberDiff line change
@@ -1207,7 +1207,7 @@ class Threads {
12071207

12081208
// Create message more options
12091209
if ((message.ownerId == this.liveStream.userId) && !message.isDeleted) {
1210-
let moreOptionAttributes = [{"class":"ch-msg-more-option ch-right"},{"title":LANGUAGE_PHRASES.MORE_OPTIONS}];
1210+
let moreOptionAttributes = [{"id":"ch_thread_message_more_option_" + message.id},{"class":"ch-msg-more-option ch-right"},{"title":LANGUAGE_PHRASES.MORE_OPTIONS}];
12111211
let moreOption = this.utility.createElement("i", moreOptionAttributes, "more_vert", msgBubbleEle);
12121212
moreOption.classList.add("material-icons");
12131213

@@ -1221,7 +1221,7 @@ class Threads {
12211221

12221222
// Create add reaction div.
12231223
if (this.reactionsSetting.enable && message.ownerId != this.liveStream.userId && !message.isDeleted) {
1224-
let addReactionEleAttributes = [{"class":"ch-add-reaction-option"},{"title":LANGUAGE_PHRASES.REACT_TO_THIS_MESSAGE}];
1224+
let addReactionEleAttributes = [{"id":"ch_thread_message_insert_emoticon_" + message.id},{"class":"ch-add-reaction-option"},{"title":LANGUAGE_PHRASES.REACT_TO_THIS_MESSAGE}];
12251225
let addReactionEle = this.utility.createElement("i", addReactionEleAttributes, "insert_emoticon", msgBubbleEle);
12261226
addReactionEle.classList.add("material-icons");
12271227

@@ -1376,18 +1376,24 @@ class Threads {
13761376
targetAttachmentCard.remove();
13771377
}
13781378

1379-
// Update listener of deleted message
1379+
// Update more option listener of deleted message
13801380
let targetMessage = document.getElementById("thread_" + data.messages[0].id);
1381-
if (targetMessage) {
1382-
let deletedMsgOptionBtn = targetMessage.lastChild;
1383-
deletedMsgOptionBtn.addEventListener("click", data => {
1381+
let moreOptionBtn = document.getElementById("ch_thread_message_more_option_" + data.messages[0].id);
1382+
if (moreOptionBtn) {
1383+
moreOptionBtn.addEventListener("click", data => {
13841384
// Remove delete for everyone option
13851385
let deleteForEveryoneBtn = document.getElementById("ch_msg_delete_for_everyone");
13861386
if (deleteForEveryoneBtn) {
13871387
deleteForEveryoneBtn.remove();
13881388
}
13891389
});
13901390
}
1391+
1392+
// Update insert emoticon listener of deleted message
1393+
let insertEmoticonBtn = document.getElementById("ch_thread_message_insert_emoticon_" + data.messages[0].id);
1394+
if (insertEmoticonBtn) {
1395+
insertEmoticonBtn.remove();
1396+
}
13911397
}
13921398

13931399
handleAddReaction(data) {

0 commit comments

Comments
 (0)
Please sign in to comment.