Skip to content

Commit b6fba57

Browse files
fixed tests
1 parent b185cab commit b6fba57

File tree

3 files changed

+34
-14
lines changed

3 files changed

+34
-14
lines changed

assets/queries/terraform/gcp/sql_db_instance_without_connections_logging/test/negative.tf

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,20 @@ resource "google_sql_database_instance" "negative_2" {
1616
settings {
1717
tier = "db-f1-micro"
1818

19-
database_flags = [
20-
{ name = "sample_flag1", value = "off" },
21-
{ name = "log_connections", value = "on" }, # Has flag set to "on"
22-
]
19+
database_flags {
20+
name = "sample_flag1"
21+
value = "off"
22+
}
23+
24+
database_flags {
25+
name = "log_connections" # Has flag set to "on"
26+
value = "on"
27+
}
28+
29+
database_flags {
30+
name = "sample_flag2"
31+
value = "off"
32+
}
2333
}
2434
}
2535

assets/queries/terraform/gcp/sql_db_instance_without_connections_logging/test/positive.tf

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@ resource "google_sql_database_instance" "positive_3" {
2020
region = "us-central1"
2121

2222
settings {
23-
database_flags = [
24-
# Missing 'log_connections' flag
25-
]
23+
database_flags {
24+
name = "sample_flag1"
25+
value = "off"
26+
} # Missing 'log_connections' flag
2627
}
2728
}
2829

@@ -32,11 +33,20 @@ resource "google_sql_database_instance" "positive_4" {
3233
region = "us-central1"
3334

3435
settings {
35-
database_flags = [
36-
{ name = "sample_flag1", value = "off" },
37-
{ name = "log_connections", value = "off" }, # Flag is not set to "on"
38-
{ name = "sample_flag2", value = "off" }
39-
]
36+
database_flags {
37+
name = "sample_flag1"
38+
value = "off"
39+
}
40+
41+
database_flags {
42+
name = "log_connections" # Flag is not set to "on"
43+
value = "off"
44+
}
45+
46+
database_flags {
47+
name = "sample_flag2"
48+
value = "off"
49+
}
4050
}
4151
}
4252

assets/queries/terraform/gcp/sql_db_instance_without_connections_logging/test/positive_expected_result.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@
1717
{
1818
"queryName": "Beta - SQL DB Instance Without Connections Logging",
1919
"severity": "MEDIUM",
20-
"line": 37
20+
"line": 42
2121
},
2222
{
2323
"queryName": "Beta - SQL DB Instance Without Connections Logging",
2424
"severity": "MEDIUM",
25-
"line": 50
25+
"line": 60
2626
}
2727
]

0 commit comments

Comments
 (0)