Fix get-configuration automation not returning defaults

While porting the get-configuration automation to run on the automation
helper, the loading of the non-confd configuration was removed. This
however broke the only callsite of this automation which was to get the
factory settings of our configuration.

We restore the old behavior of the automation by forcing it to run
outside the automation helper.

To still have some performance improvements for the global settings
page, we cache the output of this automation call in the apache process.

Slightly risky :)

co-authored-by: [email protected]

CMK-21350

Change-Id: Ia0d8144f77ea53ef9bddcbd151dd15f41bcbe916

Author: cellador

Diff for: cmk/base/automations/check_mk.py

@@ -1925,6 +1925,7 @@ def _execute_silently(
 
 
 class AutomationGetConfiguration(Automation):
+    # Automation call to get the default configuration
     cmd = "get-configuration"
     needs_config = False
     # This needed the checks in the past. This was necessary to get the
@@ -1943,21 +1944,25 @@ def execute(
         args: list[str],
         called_from_automation_helper: bool,
     ) -> GetConfigurationResult:
+        if called_from_automation_helper:
+            raise RuntimeError(
+                "This automation call should never be called from the automation helper "
+                "as it can only return the active config and we want the default config."
+            )
         # We read the list of variable names from stdin since
         # that could be too much for the command line
         variable_names = ast.literal_eval(sys.stdin.read())
 
-        if not called_from_automation_helper:
-            config.load(with_conf_d=False)
+        config.load(with_conf_d=False)
 
-            missing_variables = [v for v in variable_names if not hasattr(config, v)]
+        missing_variables = [v for v in variable_names if not hasattr(config, v)]
 
-            if missing_variables:
-                config.load_all_plugins(
-                    local_checks_dir=local_checks_dir,
-                    checks_dir=checks_dir,
-                )
-                config.load(with_conf_d=False)
+        if missing_variables:
+            config.load_all_plugins(
+                local_checks_dir=local_checks_dir,
+                checks_dir=checks_dir,
+            )
+            config.load(with_conf_d=False)
 
         result = {}
         for varname in variable_names:

Diff for: cmk/gui/watolib/check_mk_automations.py

@@ -362,6 +362,9 @@ def get_configuration(*config_var_names: str) -> results.GetConfigurationResult:
         _automation_serialized(
             "get-configuration",
             indata=list(config_var_names),
+            # We must not call this through the automation helper,
+            # see automation call execution.
+            force_cli_interface=True,
         ),
         results.GetConfigurationResult,
     )

Diff for: cmk/gui/watolib/config_domains.py

@@ -13,6 +13,7 @@
 from collections.abc import Iterable, Mapping, Sequence
 from dataclasses import dataclass, field
 from datetime import datetime
+from functools import lru_cache
 from pathlib import Path
 from typing import Any, NewType
 
@@ -88,6 +89,14 @@ def __post_init__(self) -> None:
         self.validate()
 
 
+@lru_cache
+def _core_config_default_globals(*config_var_names: str) -> Mapping[str, object]:
+    # Import cycle
+    from cmk.gui.watolib.check_mk_automations import get_configuration
+
+    return get_configuration(*config_var_names).result
+
+
 class ConfigDomainCore(ABCConfigDomain):
     @classmethod
     def ident(cls) -> ConfigDomainName:
@@ -113,10 +122,7 @@ def _parse_settings(
         return ConfigDomainCoreSettings(**activate_settings)
 
     def default_globals(self) -> Mapping[str, Any]:
-        # Import cycle
-        from cmk.gui.watolib.check_mk_automations import get_configuration
-
-        return get_configuration(*self._get_global_config_var_names()).result
+        return _core_config_default_globals(*self._get_global_config_var_names())
 
     @classmethod
     def get_domain_request(cls, settings: list[SerializedSettings]) -> DomainRequest: