Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't compile with Chia 2.3.0 #296

Open
Ealrann opened this issue May 12, 2024 · 1 comment
Open

Doesn't compile with Chia 2.3.0 #296

Ealrann opened this issue May 12, 2024 · 1 comment

Comments

@Ealrann
Copy link

Ealrann commented May 12, 2024

Hello,

The reference pool doesn't compile anymore with the last version of chia (2.3.0) because the chia.types.Announcement no longer exists.

It's used in the create_absorb_transaction method in singleton.py.
I tried to simply remove the announcements, and directly pass the coin list in create_signed_transaction, but the pool claim then fail with an error ("No key for puzzle hash", I attach the log).

Any hint how to fix the singleton.py for chia 2.3.0?

err.txt

@Ealrann Ealrann changed the title Doesn't compile whit Chia 2.3.0 Doesn't compile with Chia 2.3.0 May 12, 2024
@djerfy
Copy link

djerfy commented Jun 15, 2024

Hi @mariano54, @aqk,

Quick question on an update pool from 2.1.x to 2.3.x

In this code, need to replace Announcement by CreateCoinAccouncement?

transaction = await wallet['rpc_client'].create_signed_transaction(
            additions=[{'puzzle_hash': wallet['puzzle_hash'], 'amount': 0}],
            tx_config=DEFAULT_TX_CONFIG,
            coins=[spend_coin],
            coin_announcements=[Announcement(p2_coin.name(), b"$")],
            fee=uint64(1),
)

Same here?

transaction = await wallet['rpc_client'].create_signed_transaction(
            additions=[{'puzzle_hash': wallet['puzzle_hash'], 'amount': spend_coin.amount - fee}],
            tx_config=DEFAULT_TX_CONFIG,
            coins=[spend_coin],
            coin_announcements=[Announcement(p2_coin.name(), b"$")],
            fee=uint64(fee),
)

And here, it's AssertCoinAnnouncement?

solution: Program = w.make_solution(
        primaries=primaries,
        coin_announcements={message},
        fee=fee,
        coin_announcements_to_assert={Announcement(p2_coin.name(), bytes(b"$")).name()},
)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants