Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabindex does not work #1209

Open
svivian opened this issue Sep 24, 2024 · 4 comments · Fixed by #1239
Open

Tabindex does not work #1209

svivian opened this issue Sep 24, 2024 · 4 comments · Fixed by #1239
Assignees
Labels

Comments

@svivian
Copy link

svivian commented Sep 24, 2024

Describe the bug
The tabindex attribute on elements is ignored.

To Reproduce
Example HTML, with the select element being enhanced by Choices.js:

<input type="text" tabindex="1">
<select tabindex="2">
  <option>Example</option>
</select>
<input type="text" tabindex="3">

Expected behavior
Pressing tab should go from the text input to the dropdown then the second text input. However it skips all elements enhanced by Choices.js. The outer div (class="choices") has tabindex="0" while the inner select element has tabindex="-1" (the latter is expected as the original select shouldn't be focusable).

The tab index should be copied across to the Choices element.

Choices version and bundle

  • Version: 11.0.2

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Chrome, Firefox (latest)
@svivian svivian added the bug label Sep 24, 2024
@Xon Xon self-assigned this Sep 26, 2024
@DanielLBrown
Copy link

DanielLBrown commented Oct 16, 2024

There is also a keyboard-control issue when tabbing or shift tabbing between adjacent dropdown inputs. One dropdown remains open in spite of focus tabbing to another dropdown. Example from the demo below, Chome MacOS.
choices

@DevDuki
Copy link

DevDuki commented Nov 14, 2024

There is also a keyboard-control issue when tabbing or shift tabbing between adjacent dropdown inputs. One dropdown remains open in spite of focus tabbing to another dropdown. Example from the demo below, Chome MacOS. choices

This seriously is an issue. Cannot update from v10.2.0 without this issue being fixed

@Xon Xon closed this as completed in #1239 Dec 21, 2024
@Xon Xon closed this as completed in cd677b1 Dec 21, 2024
@svivian
Copy link
Author

svivian commented Jan 15, 2025

This issue is not fixed! Tabindex still doesn't work.

@Xon Xon reopened this Jan 19, 2025
@Xon
Copy link
Collaborator

Xon commented Jan 19, 2025

It looks like the tabindex attribute isn't being handled properly and injected into the UI, v10.2.0 didn't touch this either but since there might have been html layout changes the lack of support may be an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants