Fix linter warnings

Breaking variable namings need to be adapted

Author: moebiusband73

schema/float.go

@@ -58,7 +58,9 @@ func ConvertToFloat(input float64) Float {
 	}
 }
 
-// NaN will be serialized to `null`.
+// MarshalJSON implements the json.Marshaler interface for Float.
+// NaN values are serialized as JSON null. Regular float values are
+// formatted with 2 decimal places using fixed-point notation.
 func (f Float) MarshalJSON() ([]byte, error) {
 	if f.IsNaN() {
 		return nullAsBytes, nil
@@ -67,7 +69,9 @@ func (f Float) MarshalJSON() ([]byte, error) {
 	return strconv.AppendFloat(make([]byte, 0, 10), float64(f), 'f', 2, 64), nil
 }
 
-// `null` will be unserialized to NaN.
+// UnmarshalJSON implements the json.Unmarshaler interface for Float.
+// JSON null is deserialized as NaN. Numeric strings are parsed as float64
+// values. Returns an error if the input is neither null nor a valid number.
 func (f *Float) UnmarshalJSON(input []byte) error {
 	s := string(input)
 	if s == "null" {
@@ -105,18 +109,18 @@ func (f Float) MarshalGQL(w io.Writer) {
 	}
 }
 
-// Only used via REST-API, not via GraphQL.
-// This uses a lot less allocations per series,
-// but it turns out that the performance increase
-// from using this is not that big.
+// MarshalJSON implements the json.Marshaler interface for Series.
+// It manually builds the JSON output to reduce allocations compared to
+// encoding/json. NaN data points are serialized as null. Only used via
+// REST-API, not via GraphQL.
 func (s *Series) MarshalJSON() ([]byte, error) {
 	buf := make([]byte, 0, 512+len(s.Data)*8)
 	buf = append(buf, `{"hostname":"`...)
 	buf = append(buf, s.Hostname...)
 	buf = append(buf, '"')
-	if s.Id != nil {
+	if s.ID != nil {
 		buf = append(buf, `,"id":"`...)
-		buf = append(buf, *s.Id...)
+		buf = append(buf, *s.ID...)
 		buf = append(buf, '"')
 	}
 	buf = append(buf, `,"statistics":{"min":`...)

schema/metrics.go

@@ -45,7 +45,7 @@ type JobMetric struct {
 // Each series corresponds to one source (e.g., one node, one core) identified by Hostname and optional ID.
 // The Data field contains the time-ordered measurements, and Statistics provides min/avg/max summaries.
 type Series struct {
-	Id         *string          `json:"id,omitempty"` // Optional ID (e.g., core ID, GPU ID)
+	ID         *string          `json:"id,omitempty"` // Optional ID (e.g., core ID, GPU ID)
 	Hostname   string           `json:"hostname"`     // Source hostname
 	Data       []Float          `json:"data"`         // Time series measurements
 	Statistics MetricStatistics `json:"statistics"`   // Statistical summary (min/avg/max)
@@ -55,7 +55,7 @@ type Series struct {
 // Used when full time series data isn't needed, only the aggregated statistics.
 type ScopedStats struct {
 	Hostname string            `json:"hostname"`     // Source hostname
-	Id       *string           `json:"id,omitempty"` // Optional scope ID
+	ID       *string           `json:"id,omitempty"` // Optional scope ID
 	Data     *MetricStatistics `json:"data"`         // Statistical summary
 }
 

schema/user.go

@@ -2,6 +2,7 @@
 // All rights reserved. This file is part of cc-lib.
 // Use of this source code is governed by a MIT-style
 // license that can be found in the LICENSE file.
+
 package schema
 
 import (
@@ -16,7 +17,7 @@ type Role int
 
 const (
 	RoleAnonymous Role = iota // Unauthenticated or guest access
-	RoleApi                   // API access (programmatic/service accounts)
+	RoleAPI                   // API access (programmatic/service accounts)
 	RoleUser                  // Regular user (can view own jobs)
 	RoleManager               // Project manager (can view project jobs)
 	RoleSupport               // Support staff (can view all jobs, limited admin)
@@ -58,10 +59,12 @@ type User struct {
 	AuthSource AuthSource `json:"authSource"` // Which system authenticated the user
 }
 
+// HasProject reports whether the user is authorized for the given project name.
 func (u *User) HasProject(project string) bool {
 	return slices.Contains(u.Projects, project)
 }
 
+// GetRoleString returns the lowercase string representation of a Role enum value.
 func GetRoleString(roleInt Role) string {
 	return [6]string{"anonymous", "api", "user", "manager", "support", "admin"}[roleInt]
 }
@@ -77,19 +80,21 @@ func getRoleEnum(roleStr string) Role {
 	case "user":
 		return RoleUser
 	case "api":
-		return RoleApi
+		return RoleAPI
 	case "anonymous":
 		return RoleAnonymous
 	default:
 		return RoleError
 	}
 }
 
+// IsValidRole reports whether the given string corresponds to a known role name.
 func IsValidRole(role string) bool {
 	return getRoleEnum(role) != RoleError
 }
 
-// Check if User has SPECIFIED role AND role is VALID
+// HasValidRole checks whether the user has the specified role and whether the role string is valid.
+// Returns hasRole=true if the user has the role, and isValid=true if the role name is recognized.
 func (u *User) HasValidRole(role string) (hasRole bool, isValid bool) {
 	if IsValidRole(role) {
 		if slices.Contains(u.Roles, role) {
@@ -100,12 +105,12 @@ func (u *User) HasValidRole(role string) (hasRole bool, isValid bool) {
 	return false, false
 }
 
-// Check if User has SPECIFIED role
+// HasRole reports whether the user has the specified role.
 func (u *User) HasRole(role Role) bool {
 	return slices.Contains(u.Roles, GetRoleString(role))
 }
 
-// Check if User has ANY of the listed roles
+// HasAnyRole reports whether the user has at least one of the given roles.
 func (u *User) HasAnyRole(queryroles []Role) bool {
 	for _, ur := range u.Roles {
 		for _, qr := range queryroles {
@@ -117,7 +122,7 @@ func (u *User) HasAnyRole(queryroles []Role) bool {
 	return false
 }
 
-// Check if User has ALL of the listed roles
+// HasAllRoles reports whether the user has every one of the given roles.
 func (u *User) HasAllRoles(queryroles []Role) bool {
 	target := len(queryroles)
 	matches := 0
@@ -137,7 +142,7 @@ func (u *User) HasAllRoles(queryroles []Role) bool {
 	}
 }
 
-// Check if User has NONE of the listed roles
+// HasNotRoles reports whether the user has none of the given roles.
 func (u *User) HasNotRoles(queryroles []Role) bool {
 	matches := 0
 	for _, ur := range u.Roles {
@@ -156,11 +161,12 @@ func (u *User) HasNotRoles(queryroles []Role) bool {
 	}
 }
 
-// Called by API endpoint '/roles/' from frontend: Only required for admin config -> Check Admin Role
+// GetValidRoles returns the list of assignable role names. Only admins may call this;
+// returns an error if the user does not have the Admin role.
 func GetValidRoles(user *User) ([]string, error) {
 	var vals []string
 	if user.HasRole(RoleAdmin) {
-		for i := RoleApi; i < RoleError; i++ {
+		for i := RoleAPI; i < RoleError; i++ {
 			vals = append(vals, GetRoleString(i))
 		}
 		return vals, nil
@@ -169,19 +175,21 @@ func GetValidRoles(user *User) ([]string, error) {
 	return vals, fmt.Errorf("%s: only admins are allowed to fetch a list of roles", user.Username)
 }
 
-// Called by routerConfig web.page setup in backend: Only requires known user
+// GetValidRolesMap returns a map of role names to Role enum values. Requires any
+// authenticated (non-anonymous) user; returns an error for anonymous users.
 func GetValidRolesMap(user *User) (map[string]Role, error) {
 	named := make(map[string]Role)
 	if user.HasNotRoles([]Role{RoleAnonymous}) {
-		for i := RoleApi; i < RoleError; i++ {
+		for i := RoleAPI; i < RoleError; i++ {
 			named[GetRoleString(i)] = i
 		}
 		return named, nil
 	}
 	return named, fmt.Errorf("only known users are allowed to fetch a list of roles")
 }
 
-// Find highest role
+// GetAuthLevel returns the user's highest-privilege role.
+// Returns RoleError if the user has no recognized roles.
 func (u *User) GetAuthLevel() Role {
 	if u.HasRole(RoleAdmin) {
 		return RoleAdmin
@@ -191,8 +199,8 @@ func (u *User) GetAuthLevel() Role {
 		return RoleManager
 	} else if u.HasRole(RoleUser) {
 		return RoleUser
-	} else if u.HasRole(RoleApi) {
-		return RoleApi
+	} else if u.HasRole(RoleAPI) {
+		return RoleAPI
 	} else if u.HasRole(RoleAnonymous) {
 		return RoleAnonymous
 	} else {

schema/validate.go

@@ -2,6 +2,7 @@
 // All rights reserved. This file is part of cc-lib.
 // Use of this source code is governed by a MIT-style
 // license that can be found in the LICENSE file.
+
 package schema
 
 import (