Skip to content

Commit da781b1

Browse files
committed
rename best-of-n-orchestrator to best-of-n-editor
1 parent a9fdbc4 commit da781b1

File tree

5 files changed

+21
-21
lines changed

5 files changed

+21
-21
lines changed

.agents/base2/base2.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export function createBase2(
6262
'researcher-web',
6363
'researcher-docs',
6464
'commander',
65-
isGpt5 ? 'best-of-n-orchestrator-gpt-5' : 'best-of-n-orchestrator',
65+
isGpt5 ? 'best-of-n-editor-gpt-5' : 'best-of-n-editor',
6666
'context-pruner',
6767
),
6868

@@ -81,7 +81,7 @@ Continue to spawn layers of agents until have completed the user's request or re
8181
- **Sequence agents properly:** Keep in mind dependencies when spawning different agents. Don't spawn agents in parallel that depend on each other. Be conservative sequencing agents so they can build on each other's insights:
8282
- Spawn file pickers, code-searcher, directory-lister, glob-matcher, commanders, and web/docs researchers before making edits.
8383
${buildArray(
84-
`- Spawn a ${isGpt5 ? 'best-of-n-orchestrator-gpt-5' : 'best-of-n-orchestrator'} agent to implement the changes after you have gathered all the context you need (and not before!).`,
84+
`- Spawn a ${isGpt5 ? 'best-of-n-editor-gpt-5' : 'best-of-n-editor'} agent to implement the changes after you have gathered all the context you need (and not before!).`,
8585
).join('\n ')}
8686
- **Spawn with the correct prompt and/or params:** Each agent has a schema for the input it expects. The prompt is an optional string, and the params is a json object. Note that some agents don't take any input prompt or params.
8787
- **No need to include context:** When prompting an agent, realize that many agents can already see the entire conversation history, so you can be brief in prompting them without needing to include context.
@@ -193,7 +193,7 @@ ${buildArray(
193193
`- Spawn file pickers, code-searcher, directory-lister, glob-matcher, commanders, and web/docs researchers to gather context as needed. The file-picker-max agent in particular is very useful to use to find relevant files. Read all the relevant files using the read_files tool. Read as many files as possible so that you have a comprehensive context on the user's request.`,
194194
`- Important: Read as many files as could possibly be relevant to the task to improve your understanding of the user's request and produce the best possible code changes. This is frequently 12-20 files, depending on the task.`,
195195
`- Use the write_todos tool to write out your step-by-step implementation plan.${hasNoValidation ? '' : ' You should include at least one step to validate/test your changes: be specific about whether to typecheck, run tests, run lints, etc.'}`,
196-
`- You must spawn the ${isGpt5 ? 'best-of-n-orchestrator-gpt-5' : 'best-of-n-orchestrator'} agent to implement non-trivial code changes, since it will generate the best code changes from multiple implementation proposals. This is the best way to make high quality code changes -- strongly prefer using this agent over the str_replace or write_file tools, unless the change is very small and trivial.`,
196+
`- You must spawn the ${isGpt5 ? 'best-of-n-editor-gpt-5' : 'best-of-n-editor'} agent to implement non-trivial code changes, since it will generate the best code changes from multiple implementation proposals. This is the best way to make high quality code changes -- strongly prefer using this agent over the str_replace or write_file tools, unless the change is very small and trivial.`,
197197
!hasNoValidation &&
198198
`- Test your changes${isFast ? ' briefly' : ''} by running appropriate validation commands for the project (e.g. typechecks, tests, lints, etc.). You may have to explore the project to find the appropriate commands. Don't skip this step!`,
199199
`- Inform the user that you have completed the task in one sentence or a few short bullet points. Don't create any markdown summary files or example documentation files, unless asked by the user. If you already finished the user request and said you're done, then don't say anything else.`,
@@ -258,7 +258,7 @@ function buildImplementationStepPrompt({
258258
return buildArray(
259259
isMax &&
260260
`Keep working until the user's request is completely satisfied${!hasNoValidation ? ' and validated' : ''}. `,
261-
`You must spawn the ${isGpt5 ? 'best-of-n-orchestrator-gpt-5' : 'best-of-n-orchestrator'} agent to implement any code changes. Don't forget to do this! `,
261+
`You must spawn the ${isGpt5 ? 'best-of-n-editor-gpt-5' : 'best-of-n-editor'} agent to implement any code changes. Don't forget to do this! `,
262262
`After completing the user request, summarize your changes in a sentence or a few short bullet points. Do not create any summary markdown files or example documentation files, unless asked by the user. If you already summarized your changes, then end turn and don't say anything else.`,
263263
isGpt5 &&
264264
`IMPORTANT: if you are completely done with the user's request, you must call the task_completed tool to end your turn.`,
@@ -267,6 +267,6 @@ function buildImplementationStepPrompt({
267267

268268
function buildPlanOnlyStepPrompt({}: {}) {
269269
return buildArray(
270-
`Your are in plan mode. Do not make any file changes. Do not call write_file or str_replace. Do not spawn the best-of-n-orchestrator agent to implement. Do not use the write_todos tool.`,
270+
`Your are in plan mode. Do not make any file changes. Do not call write_file or str_replace. Do not spawn the best-of-n-editor agent to implement. Do not use the write_todos tool.`,
271271
).join('\n')
272272
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import { createBestOfNEditor } from './best-of-n-editor'
2+
3+
const definition = {
4+
...createBestOfNEditor('gpt-5'),
5+
id: 'best-of-n-editor-gpt-5',
6+
}
7+
export default definition

.agents/base2/best-of-n/best-of-n-orchestrator.ts renamed to .agents/base2/best-of-n/best-of-n-editor.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ import type {
55
AgentStepContext,
66
StepText,
77
ToolCall,
8-
} from 'types/agent-definition'
8+
} from '../../types/agent-definition'
99

10-
export function createBestOfNOrchestrator(
10+
export function createBestOfNEditor(
1111
model: 'sonnet' | 'gpt-5',
1212
): Omit<SecretAgentDefinition, 'id'> {
1313
const isGpt5 = model === 'gpt-5'
@@ -16,10 +16,10 @@ export function createBestOfNOrchestrator(
1616
publisher,
1717
model: isGpt5 ? 'openai/gpt-5' : 'anthropic/claude-sonnet-4.5',
1818
displayName: isGpt5
19-
? 'Best-of-N GPT-5 Implementation Orchestrator'
20-
: 'Best-of-N Fast Implementation Orchestrator',
19+
? 'Best-of-N GPT-5 Implementation Editor'
20+
: 'Best-of-N Fast Implementation Editor',
2121
spawnerPrompt:
22-
'Orchestrates multiple implementor agents to generate implementation proposals, selects the best one, and applies the changes. Do not specify an input prompt for this agent; it reads the context from the message history.',
22+
'Edits code by orchestrating multiple implementor agents to generate implementation proposals, selects the best one, and applies the changes. Do not specify an input prompt for this agent; it reads the context from the message history.',
2323

2424
includeMessageHistory: true,
2525
inheritParentSystemPrompt: true,
@@ -310,7 +310,7 @@ function* handleStepsGpt5({
310310
}
311311

312312
const definition = {
313-
...createBestOfNOrchestrator('sonnet'),
314-
id: 'best-of-n-orchestrator',
313+
...createBestOfNEditor('sonnet'),
314+
id: 'best-of-n-editor',
315315
}
316316
export default definition

.agents/base2/best-of-n/best-of-n-orchestrator-gpt-5.ts

Lines changed: 0 additions & 7 deletions
This file was deleted.

.agents/base2/task-researcher/base2-gpt-5-worker.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const definition: SecretAgentDefinition = {
1818
'researcher-web',
1919
'researcher-docs',
2020
'commander',
21-
'best-of-n-orchestrator',
21+
'best-of-n-editor-gpt-5',
2222
'context-pruner',
2323
),
2424

@@ -32,7 +32,7 @@ The user asks you to implement a new feature. You respond in multiple steps:
3232
3333
- Gather context on the user's request by spawning agents and reading files.
3434
- Use the write_todos tool to write out your step-by-step implementation plan.
35-
- Use the best-of-n-orchestrator tool to implement the changes. This is the best way to make high quality code changes -- strongly prefer using this agent over the str_replace or write_file tool.
35+
- Use the best-of-n-editor-gpt-5 tool to implement the changes. This is the best way to make high quality code changes -- strongly prefer using this agent over the str_replace or write_file tool.
3636
- For smaller fixes, use the str_replace or write_file tool to make the changes.
3737
- Test your changes by running appropriate validation commands for the project (e.g. typechecks, tests, lints, etc.). You may have to explore the project to find the appropriate commands.`,
3838

0 commit comments

Comments
 (0)