Fix job details popover sticking after cancel/delete #6930
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
🎭 Playwright Test Results⏰ Completed at: 11/25/2025, 09:58:47 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/25/2025, 09:49:52 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.18 MB (baseline 3.18 MB) • ⚪ 0 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 945 kB (baseline 944 kB) • 🔴 +796 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 297 kB (baseline 297 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 139 kB (baseline 139 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.84 MB (baseline 3.84 MB) • ⚪ 0 BBundles that do not match a named category
Status: 18 added / 18 removed |
Member
Author
Is timing out, pretty sure it's unrelated. |
Comment on lines
+94
to
+111
| const allJobIds = computed(() => | ||
| displayedJobGroups.value.flatMap((group) => | ||
| group.items.map((item) => item.id) | ||
| ) | ||
| ) | ||
| watch(allJobIds, (ids) => { | ||
| if (activeDetailsId.value && !ids.includes(activeDetailsId.value)) { | ||
| clearHideTimer() | ||
| clearShowTimer() | ||
| activeDetailsId.value = null | ||
| } | ||
| }) | ||
| onBeforeUnmount(() => { | ||
| clearHideTimer() | ||
| clearShowTimer() | ||
| }) |
Contributor
There was a problem hiding this comment.
How expensive is this with a long history?
Member
Author
There was a problem hiding this comment.
We have a maxhistory of 64, if that gets removed, then it might be bad after a few thousand? Technically speaking this can be removed and each case handled on its own.
Contributor
There was a problem hiding this comment.
We do plan to allow scrolling through history and not removing the tail and the maxhistory is configurable right? This isn't really blocking though
DrJKL
reviewed
Nov 26, 2025
| defineProps<{ displayedJobGroups: JobGroup[] }>() | ||
| const props = defineProps<{ displayedJobGroups: JobGroup[] }>() | ||
| const displayedJobGroups = computed(() => props.displayedJobGroups) |
christian-byrne
approved these changes
Nov 27, 2025
Member
Author
|
I see the replies and will get to the fixes soon it's technically not blocking, yes, but like, it's probably going to get lost after someone merges but of course now that I say that explicitly it'll never get lost and haunt me until I fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6907
Testing
┆Issue is synchronized with this Notion page by Unito