CMP-3978: Incorporate SSH version into obsolete parameter rules #14189
+92
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rhmdnd
commented
Nov 26, 2025
rhmdnd
commented
- Add parameter for obsolete sshd configuration options
- Only check ssh protocol if openssh < 7.0
- Only check UsePrivilegeSeparation if openssh < 7.5
Certain SSH options are obsolete in that even if you set the value, OpenSSH is going to ignore it. This is true for UsePrivilegeSeparation, Protocol, and RhostsRSAAuthentication options. This commit updates the SSH oval templates to add another template variable called `obsolete_since_version` which gives us the flexibility of saying "only run this rule if the system has a version of OpenSSH less than version X". Otherwise, the check will short-circuit since OpenSSH is defaulting to a more secure configuration. This makes the rules more accurate, even if a user is setting something that doesn't make sense at run time (e.g., Protocol 1).
OpenSSH made the `Protocol` option obsolete in version 7.0. Even if you
try to specify it, it's not going to use the version you set for
security reasons:
Potentially-incompatible Changes
--------------------------------
* Support for the legacy SSH version 1 protocol is disabled by
default at compile time.
See the release notes for version 7.0 for more details.
https://www.openssh.org/releasenotes.html
OpenSSH hardcoded the `UsePrivilegeSeparation` option to `sandbox` in
7.5:
Potentially-incompatible changes
================================
This release includes a number of changes that may affect existing
configurations:
* This release deprecates the sshd_config UsePrivilegeSeparation
option, thereby making privilege separation mandatory. Privilege
separation has been on by default for almost 15 years and
sandboxing has been on by default for almost the last five.
https://www.openssh.org/releasenotes.html
Let's only check it if the ssh version is applicable.
rhmdnd
commented
Nov 26, 2025
| <criteria comment="sshd installed and option is obsolete" operator="AND"> | ||
| <extend_definition comment="sshd is required or requirement is unset" | ||
| definition_ref="sshd_required_or_unset" /> | ||
| {{% if product == "sle12" %}} |
Collaborator
Author
There was a problem hiding this comment.
We may need other package manager support here?
rhmdnd
changed the title
|
@rhmdnd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
|
Why not just |
Member
|
See: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.