Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving Columns from Prelude #294

Open
DavePearce opened this issue Nov 7, 2024 · 0 comments
Open

Resolving Columns from Prelude #294

DavePearce opened this issue Nov 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@DavePearce
Copy link
Collaborator

The following example compiles without problem:

(defcolumns X)
(module m1)
(defcolumns Y)
(defconstraint tmp () (vanishes! (* X Y)))

This should be an error, since are not permitted to mix columns in the same constraint from different modules. The generated wizard-iop is, for example:

func ZkEVMDefine(build *Builder) {
	//
	// Corset-computed columns
	//
	_prelude___X := build.RegisterCommit("X", build.Settings.Traces.Prelude)
	m1__Y := build.RegisterCommit("m1.Y", build.Settings.Traces.M1)

	//
	// Constraints
	//
	build.GlobalConstraint("m1.tmp", _prelude___X.AsVariable().Mul(m1__Y.AsVariable()))
}
@DavePearce DavePearce added the bug Something isn't working label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant