Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check rotation length in uints package method Lrot #1150

Open
ivokub opened this issue May 31, 2024 · 0 comments
Open

chore: check rotation length in uints package method Lrot #1150

ivokub opened this issue May 31, 2024 · 0 comments
Assignees
Labels
consolidate strengthen an existing feature

Comments

@ivokub
Copy link
Collaborator

ivokub commented May 31, 2024

Currently the rotation can be more than the full length of the underlying type (i.e. for U64 we can provide rotation which is greater than 64 bits). For clarity and avoiding unnecessary edge cases, we should restrict the rotation length to be strictly less than the width of the underlying type.

Additionally - we currently only have left rotation but could implement right rotation as a wrapper around light rotation.

@ivokub ivokub added the consolidate strengthen an existing feature label May 31, 2024
@ivokub ivokub self-assigned this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consolidate strengthen an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant