-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Register scope detail #671
Comments
The Non-normative Examples for the Register endpoints could also be updated: Non-Normative Example - Data Recipient Software Product requests CDR Register Access Token
POST /token HTTP/1.1
- Host: cdr.register
+ Host: secure.api.cdr.gov.au
- scope=cdr-register%3Abank%3Aread
+ scope=cdr-register%3Aread
- "aud": "https://cdr.register/idp/connect/token",
+ "aud": "https://secure.api.cdr.gov.au/idp/connect/token",
- "scope": "cdr-register:bank:read openid"
+ "scope": "cdr-register:read openid" and Retrieve CDR Register OIDC Discovery Endpoint
- GET /.well-known/openid-configuration HTTP/1.1
+ GET /idp/.well-known/openid-configuration HTTP/1.1
- Host: cdr.register
+ Host: api.cdr.gov.au
- "issuer": "https://cdr.register/idp",
+ "issuer": "https://secure.api.cdr.gov.au/idp",
- "jwks_uri": "https://cdr.register/idp/.well-known/openid-configuration/jwks",
+ "jwks_uri": "https://api.cdr.gov.au/idp/.well-known/openid-configuration/jwks",
- "token_endpoint": "https://cdr.register/idp/connect/token",
+ "token_endpoint": "https://secure.api.cdr.gov.au/idp/connect/token",
- "scopes_supported": ["cdr-register:bank:read"],
+ "scopes_supported": ["cdr-register:read"],
- "scope": "cdr-register:bank:read openid"
+ "scope": "cdr-register:read openid" and references to: could be reviewed in relation to the following statement in Data Recipients calling the CDR Register:
|
They are non-normative but the suggested update includes a host update to something "real", not sure if that's intentional but if it is it's incorrect as the discovery document is at Also, since we're on the topic, the Register is in violation of RFC8615 based on the following statement: |
Thanks @perlboy, I've marked that line to be updated as well (ref). For reference, changes to the server values in the Register endpoint spec have also been staged for the next release. Unless I misunderstand, as the Register well-known is effectively being provided out of band and the issuer has a path component, according to OIDC that can be valid? I understand some Data Holders have similar patterns. |
It was more a reference to the well-known RFC spec which bans it (and OpenID overrides when discovered via WebFinger). In the ACCC case:
|
Description
The Admin & Registration section contains details of scopes for Data Holder Admin and DCR endpoints, and Register endpoints used by Data Recipients.
Intention and Value of Change
To remove details of the deprecated Register scope:
cdr-register:bank:read
Area Affected
Change Proposed
Replace the existing rows:
This scope is valid for the following endpoint versions:
- GetDataHolderBrands V1
- GetSoftwareStatementAssertion V2
This scope is replaced bycdr-register:read
for newer versions of these endpoints.Replaces
cdr-register:bank:read
for the following endpoint versions:with only a single row for the current valid scope:
cdr-register:read
The text was updated successfully, but these errors were encountered: