-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Error Code for Product Data Requests where the Data Holder does not hold the required Product Reference Data #678
Comments
Note that we have been speaking to another DH who is currently returning 404 and they agree that this is incorrect and will be updating their implementation to match the current standards by returning a HTTP 200 and an empty JSON array. As such, I do not believe a change in standards is needed here as there appears to be a solution accepted by the majority of DHs already. |
This issue was discussed in the MI call today. Participants noted:
|
Can further information on use case be provided here please? From my current understanding of the use case, providing a 404 response specifically to "known but no data available" requests implies that, in fact, there is data available and if this is the case and the product is in market it's mandated anyway. Going per sector:
As @nils-work has highlighted, this request seems to be working around a Register design flaw that's been highlighted for years. Fix the source of the problem rather than hack in workarounds. |
Description
Currently, there are four endpoints for Product Reference Data defined in the CDR Standards which Data Holders are obligated to support:
However, there is no defined error response under the CDR Standards – Error Codes for scenarios where a Data Holder does not hold the Product Reference Data being requested. This includes scenarios such as:
In these scenarios, a Data Holder may still be required to:
Intention and Value of Change
It is unclear whether the above approach would achieve a better consumer outcome than an appropriately labelled ‘404 error’ response that similarly conveys to the requestor that there are no relevant products/data available, and it may be costly and complex to build (and maintain) the required error handling for each Product Reference Data endpoint without significant consumer benefit.
As a result, we propose to introduce the below new error response to:
Area Affected
High Level Standards - Error Codes
Banking APIs - GET Products
Energy APIs - GET Generic Plans
Change Proposed
A new response is added to each Product Reference Data Endpoint:
With a new 404 (Not Found) Error Code added under the Consumer Data Standards, Error Codes, such as:
The text was updated successfully, but these errors were encountered: