Merge pull request #6 from CoverGenius/php8-compat-typing

specialtactics · web-flow · commit 092de0637df0 · 2022-11-16T15:23:16.000+11:00
Add bool type in filter function for php 8 compat
diff --git a/src/VCR/CodeTransform/AbstractCodeTransform.php b/src/VCR/CodeTransform/AbstractCodeTransform.php
@@ -30,14 +30,14 @@ public function register(): void
      *
      * @param resource $in
      * @param resource $out
-     * @param int      $consumed
+     * @param int      &$consumed
      * @param bool     $closing
      *
      * @return int PSFS_PASS_ON
      *
      * @see http://www.php.net/manual/en/php-user-filter.filter.php
      */
-    public function filter($in, $out, &$consumed, $closing): int
+    public function filter($in, $out, &$consumed, bool $closing): int
     {
         while ($bucket = stream_bucket_make_writeable($in)) {
             $bucket->data = $this->transformCode($bucket->data);

Original file line number	Diff line number	Diff line change
`@@ -30,14 +30,14 @@ public function register(): void`
`30`	`30`	`*`
`31`	`31`	`* @param resource $in`
`32`	`32`	`* @param resource $out`
`33`		`- * @param int $consumed`
	`33`	`+ * @param int &$consumed`
`34`	`34`	`* @param bool $closing`
`35`	`35`	`*`
`36`	`36`	`* @return int PSFS_PASS_ON`
`37`	`37`	`*`
`38`	`38`	`* @see http://www.php.net/manual/en/php-user-filter.filter.php`
`39`	`39`	`*/`
`40`		`- public function filter($in, $out, &$consumed, $closing): int`
	`40`	`+ public function filter($in, $out, &$consumed, bool $closing): int`
`41`	`41`	`{`
`42`	`42`	`while ($bucket = stream_bucket_make_writeable($in)) {`
`43`	`43`	`$bucket->data = $this->transformCode($bucket->data);`