Skip to content

Commit cb6c7b4

Browse files
authored
Prevent codecov status checks from failing (#317)
We have wide variability of our total coverage reports even for non-substantive commits. We suspect that this is because we are compiling unit tests and the SmartRedis library in cmake's Release mode which enables -O3 and may, at worse, skip the execution of some tests and at least confuses the tracer that marks which lines have been run. As a workaround for now, we are lowering the target thresholds to 0% so that commits are not marked with the dreaded 'X' due to the variance that results in code coverage.
1 parent 49e7cc3 commit cb6c7b4

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

codecov.yml

+6-4
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@ coverage:
55
status:
66
project:
77
default:
8-
target: 60%
9-
threshold: 2%
8+
target: 0%
9+
patch:
10+
default:
11+
target: 0%
1012

1113
parsers:
1214
gcov:
@@ -19,6 +21,6 @@ parsers:
1921
comment:
2022
layout: "reach,diff,flags,files"
2123
behavior: default # update comment if already exists, otherwise post new
22-
require_changes: no
23-
require_base: no
24+
require_changes: yes
25+
require_base: yes
2426
require_head: yes

doc/changelog.rst

+4
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ This section details changes made in the development branch that have not yet be
1212

1313
Description
1414

15+
16+
- Disable codecov CI tests
1517
- Improved error message in to_string methods in C interface
1618
- Streamlined PyBind interface layer
1719
- Updated Python API documentation
@@ -44,6 +46,7 @@ Description
4446

4547
Detailed Notes
4648

49+
- Remove codecov thresholds to avoid commits being marked as 'failed' due to coverage variance (PR317_)
4750
- Corrected the error message in to_string methods in C interface to not overwrite the returned error message and to name the function (PR320_)
4851
- Streamlined PyBind interface layer to reduce repetitive boilerplate code (PR315_)
4952
- Updated Python API summary table to include new methods (PR313_)
@@ -78,6 +81,7 @@ Detailed Notes
7881
- Implemented support for Unix Domain Sockets, including refactorization of server address code, test cases, and check-in tests. (PR252_)
7982
- A new make target `make lib-with-fortran` now compiles the Fortran client and dataset into its own library which applications can link against (PR245_)
8083

84+
.. _PR317: https://github.com/CrayLabs/SmartRedis/pull/317
8185
.. _PR315: https://github.com/CrayLabs/SmartRedis/pull/320
8286
.. _PR315: https://github.com/CrayLabs/SmartRedis/pull/315
8387
.. _PR313: https://github.com/CrayLabs/SmartRedis/pull/313

0 commit comments

Comments
 (0)