Skip to content

Commit 63c4098

Browse files
author
Al Rigazzi
authored
Fix patch for rocm6.3 (#793)
The header for ROCM 6.3.4 is not compatible with PyTorch 2.7.1's CMakeFind module's regex and we need to patch it post-download. Additionally, an old patch is not useful anymore and has been removed. [ committed by @al-rigazzi ] [ reviewed bu @MattToast ]
1 parent fb0ea1f commit 63c4098

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ htmlcov
88
smartsim.egg-info
99
tests/test_output
1010
.DS_Store
11+
build
1112

1213
# Dependencies
1314
smartsim/_core/.third-party

doc/changelog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ To be released at some point in the future
1111

1212
Description
1313

14+
- Update install patch for PyTorch 2.7.1+rocm6.3
1415
- Modernize typing syntax to Python 3.10+ standards
1516
- Removed telemetry functionality, LaunchedManifest tracking
1617
classes, and SmartDashboard integration
@@ -26,6 +27,9 @@ Description
2627

2728
Detailed Notes
2829

30+
- Updated the post-install patch which is applied to the Caffe2/PyTorch
31+
CMakeFind module.
32+
([SmartSim-PR793](https://github.com/CrayLabs/SmartSim/pull/793))
2933
- Modernized typing syntax to use Python 3.10+ standards, replacing
3034
`Union[X, Y]` with `X | Y`, `Optional[X]` with `X | None`, and generic
3135
collections (`List[X]``list[X]`, `Dict[X, Y]``dict[X, Y]`, etc.).

smartsim/_core/_install/configs/mlpackages/LinuxX64ROCM6.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@
3030
"replacement": "set_property(TARGET torch_c PROPERTY CXX_STANDARD 17)"
3131
},
3232
{
33-
"description": "Fix Regex, Load HIP",
33+
"description": "Fix LoadHIP.cmake regex to match tabs in ROCm version header",
3434
"source_file": "../package/libtorch/share/cmake/Caffe2/public/LoadHIP.cmake",
35-
"regex": ".*string.*",
36-
"replacement": ""
35+
"regex": "\\[ \\]\\+",
36+
"replacement": "[ \\\\t]+"
3737
},
3838
{
3939
"description": "Replace `/opt/rocm` with `$ENV{ROCM_PATH}`",

0 commit comments

Comments
 (0)