Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checkboxes from tags multi-select filters (members page) #1678

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove checkboxes from tags multi-select filters (members page) #1678

wants to merge 6 commits into from

Conversation

peoray
Copy link
Contributor

@peoray peoray commented Oct 14, 2023 •
edited by ghost
Loading

Changes proposed ✍️

Fixes #1600

What

🤖 Generated by Copilot at 33db278

Prevent v-select rendering for tags filter in MultiSelectAsyncFilter component. This fixes a bug where the tags filter would not work properly with the v-select component.
​

🤖 Generated by Copilot at 33db278

v-select hidden
when config.id is tags
autumn leaves filter

Why

How

🤖 Generated by Copilot at 33db278

  • Prevent tags filter from rendering v-select component by adding conditional logic based on config.id prop (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

joanagmaia
joanagmaia reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @peoray, I just aligned with @nunoeufrasio, our product designer, on this issue.
I believe the goal is a bit more complex than just removing the checkboxes from the select options.
The goal would be to:

  1. Remove checkboxes from tags
  2. Once option is selected, the option is removed from the list (since it is displayed as a tag in the main input). If tag is removed, option should be re-added to the list

Sorry that this wasn't clear in the issue. I'm gonna update the issue's description as well

@peoray
Copy link
Contributor Author

peoray commented Oct 19, 2023

@joanagmaia take a look when you can :)

@peoray
Copy link
Contributor Author

peoray commented Nov 20, 2023

@joanagmaia any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanagmaia joanagmaia joanagmaia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-select (tags) filters without checkboxes
2 participants
@peoray @joanagmaia