Add message on successful dry run

gergness · gergness · commit d8fbf32be82e · 2021-04-20T09:56:26.000-05:00
diff --git a/R/automation.R b/R/automation.R
@@ -144,11 +144,14 @@ runCrunchAutomation <- function(dataset, script, is_file = string_is_file_like(s
     }
     if (length(script) != 1) script <- paste(script, collapse = "\n")
 
+    body <- list(body = script, ...)
     crPOST(
         shojiURL(dataset, "catalogs", "scripts"),
-        body = toJSON(wrapEntity(body = list(body = script, ...))),
+        body = toJSON(wrapEntity(body = body)),
         status.handlers = list(`400` = crunchAutomationErrorHandler)
     )
+    # Provide feedback for dry_run success so that user is confident it was succesful
+    if (isTRUE(body$dry_run)) message("Script dry run was successful")
     invisible(refresh(dataset))
 }
 

Original file line number	Diff line number	Diff line change
`@@ -144,11 +144,14 @@ runCrunchAutomation <- function(dataset, script, is_file = string_is_file_like(s`
`144`	`144`	`}`
`145`	`145`	`if (length(script) != 1) script <- paste(script, collapse = "\n")`
`146`	`146`
	`147`	`+ body <- list(body = script, ...)`
`147`	`148`	`crPOST(`
`148`	`149`	`shojiURL(dataset, "catalogs", "scripts"),`
`149`		`- body = toJSON(wrapEntity(body = list(body = script, ...))),`
	`150`	`+ body = toJSON(wrapEntity(body = body)),`
`150`	`151`	status.handlers = list(`400` = crunchAutomationErrorHandler)
`151`	`152`	`)`
	`153`	`+ # Provide feedback for dry_run success so that user is confident it was succesful`
	`154`	`+ if (isTRUE(body$dry_run)) message("Script dry run was successful")`
`152`	`155`	`invisible(refresh(dataset))`
`153`	`156`	`}`
`154`	`157`