Hi,
on my own branch (with a couple more fixes) there is one warning remaining that I don't know how to fix:
../src/ui.c:3755:29: warning: converting the enum constant to a boolean [-Wint-in-bool-context]
(keytagactive == FALSE && SC_KEY_TAGACTION)) && ic != -1) {
|
if(((keytagactive == TRUE && sc != SC_KEY_TAGACTION) || |
|
(keytagactive == FALSE && SC_KEY_TAGACTION)) && ic != -1) { |
|
keytagactive = FALSE; |
|
refscr = TRUE; |
|
curs_set(0); |
|
remln(COLS); |
|
} |
Now the enum constant isn't zero (afaict), so should evaluate to true, and one could simply remove && SC_KEY_TAGACTION to remove the warning and keep the current semantic, but that probably wasn't the intention.
Other options probably are sc == SC_KEY_TAGACTION or sc != SC_KEY_TAGACTION (but the latter would reduce the whole condition to sc != SC_KEY_TAGACTION && ic != -1, ignoring keytagactive).
Hi,
on my own branch (with a couple more fixes) there is one warning remaining that I don't know how to fix:
apt-dater/src/ui.c
Lines 3754 to 3760 in 113ea9b
Now the enum constant isn't zero (afaict), so should evaluate to true, and one could simply remove
&& SC_KEY_TAGACTIONto remove the warning and keep the current semantic, but that probably wasn't the intention.Other options probably are
sc == SC_KEY_TAGACTIONorsc != SC_KEY_TAGACTION(but the latter would reduce the whole condition tosc != SC_KEY_TAGACTION && ic != -1, ignoringkeytagactive).