lint

Author: ltello

app/migration/cache_manager.rb

@@ -103,9 +103,9 @@ def cache_school_partnerships
   def cache_teachers
     return if [@teachers_by_trn, @teachers_by_api_ect_training_record_id, @teachers_by_api_mentor_training_record_id].all?(&:present?)
 
-    @teachers_by_trn ||= ::Teacher.all.index_by(&:trn)
-    @teachers_by_api_ect_training_record_id ||= ::Teacher.all.index_by(&:api_ect_training_record_id)
-    @teachers_by_api_mentor_training_record_id ||= ::Teacher.all.index_by(&:api_mentor_training_record_id)
+    @teachers_by_trn = ::Teacher.all.index_by(&:trn)
+    @teachers_by_api_ect_training_record_id = ::Teacher.all.index_by(&:api_ect_training_record_id)
+    @teachers_by_api_mentor_training_record_id = ::Teacher.all.index_by(&:api_mentor_training_record_id)
 
     @cache_loads[:teachers] += 1
   end

app/migration/migrators/declaration.rb

@@ -72,7 +72,7 @@ def delivery_partner_when_created(participant_declaration:)
     end
 
     def payment_statement(participant_declaration:)
-      if ecf_payment_statement_id = participant_declaration.payment_statement&.id
+      if (ecf_payment_statement_id = participant_declaration.payment_statement&.id)
         statement_from_ecf_id(ecf_payment_statement_id)
       end
     end

app/models/migration/participant_declaration.rb

@@ -1,6 +1,5 @@
 module Migration
   class ParticipantDeclaration < Migration::Base
-
     BILLABLE_STATES = %w[eligible payable paid voided].freeze
     REFUNDABLE_STATES = %w[awaiting_clawback clawed_back].freeze
 

spec/factories/migration/participant_declaration_factory.rb

@@ -5,7 +5,7 @@
     cohort { FactoryBot.create(:migration_cohort) }
 
     declaration_type { "started" }
-    declaration_date { Faker::Date.between(from: 2.years.ago, to: 1.day.ago) }
+    declaration_date { Time.zone.today }
     course_identifier { "ecf-induction" }
     evidence_held { "other" }
     state { "submitted" }

spec/migration/migrators/declaration_spec.rb

@@ -87,4 +87,3 @@ def setup_failure_state
     end
   end
 end
-