Add first purchase date to portfolio CSV results#160
Open
folefacb wants to merge 2 commits intoDFIC-Quant-Fund:mainfrom
Open
Add first purchase date to portfolio CSV results#160folefacb wants to merge 2 commits intoDFIC-Quant-Fund:mainfrom
folefacb wants to merge 2 commits intoDFIC-Quant-Fund:mainfrom
Conversation
BigBird119
suggested changes
Feb 22, 2026
There was a problem hiding this comment.
Can you also ensure this actually shows up in the holdings table as a column via the src/views/holdings_table file. Ask Cursor and it'll be clear how this is done - should be simple. Once you do that, include a screenshot in this PR to show the change please.
Collaborator
|
BigBird is my other account lol |
Added 'first_purchase_date' column and updated its display configuration. Adjusted comments for clarity and consistency.
Collaborator
|
Just add the screenshot with the table showing the new column and the text "Closes #148" so it closes your Issue |
Contributor
Author
FYI, i tried recompiling the the "build_all_portfolios" file but i think I have some connection issue with Yahoo Finance so I created individual csv files with just a couple tickers to test if my adjusted codes actually work. Closes #148 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new column to the holdings table showing the first purchase date per ticker.