Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The _MPI macros should also work if not compiled with MPI #2

Open
holke opened this issue Mar 15, 2021 · 0 comments
Open

The _MPI macros should also work if not compiled with MPI #2

holke opened this issue Mar 15, 2021 · 0 comments
Assignees
@holke
Labels
bug Something isn't working enhancement New feature or request

Comments

@holke
Copy link
Collaborator

holke commented Mar 15, 2021

If we disable MPI support (with -DGTEST_HAS_MPI=0) then the new *_MPI macros are not defined causing compiler errors in code using them. Instead, they should be defined to their non-mpi counterparts to make code using the *_MPI macros behave like expected (as serial code) if compiled without MPI support.
@holke holke added bug Something isn't working enhancement New feature or request labels Mar 15, 2021
@holke holke self-assigned this Mar 15, 2021
holke pushed a commit that referenced this issue Feb 1, 2024
@derekmauro
Googletest export
0a3a3a8 
Make include guards conform with https://google.github.io/styleguide/cppguide.html#The__define_Guard, attempt #2

PiperOrigin-RevId: 357056902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holke holke

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@holke