Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing output in XML files for np>1 #4

Open
holke opened this issue Mar 15, 2021 · 2 comments
Open

missing output in XML files for np>1 #4

holke opened this issue Mar 15, 2021 · 2 comments

Comments

@holke
Copy link
Collaborator

holke commented Mar 15, 2021

If an error occurs on rank k!=0, the message is lost because there is only a reduction on the test result to verify the test failed. On Jenkins we therefore see only the file and line where the test failed, not the details.

See also the corresponding PHIST issue:

https://bitbucket.org/essex/phist/issues/174/missing-test-output-in-xml-files

@holke
Copy link
Collaborator Author

holke commented Mar 15, 2021

@melven is this still an issue?

Can this be solved with one of the MPI listeners? @holke needs to investigate.

@melven
Copy link

melven commented Mar 16, 2021

This is still an issue but this is kind-of a decision about overhead and usability.

Very roughly without looking into the code again:

You could make some kind of allreduce of the error messages and join them to one (longer) error message... Jonas tried this once and reverted it later if I remember correctly...

  • overhead: for >1k processes string parsing / concatenating will get more costly - and I'm not sure if you can do this only if an error occurs because there are things like expected failures, etc. (so you might end up doing this always for all expect/assert-statements)
  • usability:
    • Printing all error messages easily gets ugly - you could try to combine them though - or print the error of the process with the smallest rank
    • And I'm reluctant to change the output because there might be other tools that parse the googletest output.
      (this is of course also a problem with the current approach where the real message is missing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants