Don't allow no_paging for metadata type retrievals.

Author: ldecicco-USGS

R/get_ogc_data.R

@@ -28,9 +28,13 @@ get_ogc_data <- function(args,
   args[["max_results"]] <- NULL
 
   req <- do.call(construct_api_requests, args)
-  
-  no_paging <- args[["no_paging"]]
-  args[["no_paging"]] <- NULL
+
+  if("no_paging" %in% names(args)){
+    no_paging <- args[["no_paging"]]
+    args[["no_paging"]] <- NULL    
+  } else {
+    no_paging <- FALSE
+  }
 
   if(no_paging){
     return_list <- get_csv(req, max_results)

R/read_waterdata_monitoring_location.R

@@ -63,10 +63,6 @@
 #' @param skipGeometry This option can be used to skip response geometries for
 #' each feature. The returning object will be a data frame with no spatial
 #' information.
-#' @param no_paging logical, defaults to `FALSE`. If `TRUE`, the data will
-#' be requested from a native csv format. This can be dangerous because the
-#' data will cut off at 50,000 rows without indication that more data
-#' is available. Use `TRUE` with caution. 
 #' @examplesIf is_dataRetrieval_user()
 #' 
 #' \donttest{
@@ -140,8 +136,7 @@ read_waterdata_monitoring_location <- function(monitoring_location_id = NA_chara
                             bbox = NA,
                             limit = NA,
                             max_results = NA,
-                            skipGeometry = NA,
-                            no_paging = FALSE){
+                            skipGeometry = NA){
 
   service <- "monitoring-locations"
   output_id <- "monitoring_location_id"

R/read_waterdata_parameter_codes.R

@@ -67,7 +67,7 @@ read_waterdata_parameter_codes <- function(parameter_code = NA_character_,
   args[["convertType"]] <- FALSE
   args[["skipGeometry"]] <- TRUE
   args[["bbox"]] <- NA
-  args[["no_paging"]] <- TRUE # change if we're ever over 50,000
+  args[["no_paging"]] <- FALSE # change if we're ever over 50,000
 
   if(all(lengths(args) == 1)){
     return_list <- suppressWarnings(get_ogc_data(args = args,
@@ -76,9 +76,7 @@ read_waterdata_parameter_codes <- function(parameter_code = NA_character_,
   } else {
 
     message("Current API functionality requires pulling the full parameter-codes list.
-It is expected that updates to the API will eliminate this need, but in the meantime
-consider running read_waterdata_parameter_code() with no query parameters, and filtering
-in a post-processing step.")
+It is expected that updates to the API will eliminate this need.")
 
     return_list <- read_waterdata_metadata(collection = service, 
                                  max_results = max_results,