Skip to content

Commit 002b172

Browse files
committed
Fix Linux build by not closing a null pointer
Fixes: src/processor/exploitability_linux.cc: In static member function ‘static bool google_breakpad::ExploitabilityLinux::DisassembleBytes(const std::string&, const uint8_t*, unsigned int, char*)’: src/processor/exploitability_linux.cc:519:11: error: argument 1 null where non-null expected [-Werror=nonnull] 519 | fclose(objdump_fp); | ~~~~~~^~~~~~~~~~~~ In file included from /usr/include/c++/13/cstdio:42, from /usr/include/c++/13/ext/string_conversions.h:45, from /usr/include/c++/13/bits/basic_string.h:4097, from /usr/include/c++/13/string:54, from /usr/include/c++/13/bits/locale_classes.h:40, from /usr/include/c++/13/bits/ios_base.h:41, from /usr/include/c++/13/ios:44, from /usr/include/c++/13/ostream:40, from /usr/include/c++/13/iostream:41, from ./src/google_breakpad/processor/minidump.h:88, from ./src/google_breakpad/processor/exploitability.h:44, from ./src/processor/exploitability_linux.h:41, from src/processor/exploitability_linux.cc:37: /usr/include/stdio.h:183:12: note: in a call to function ‘int fclose(FILE*)’ declared ‘nonnull’ 183 | extern int fclose (FILE *__stream) __nonnull ((1)); |
1 parent ad7fca3 commit 002b172

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/processor/exploitability_linux.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,6 @@ bool ExploitabilityLinux::DisassembleBytes(const string &architecture,
516516
raw_bytes_tmpfile);
517517
FILE *objdump_fp = popen(cmd, "r");
518518
if (!objdump_fp) {
519-
fclose(objdump_fp);
520519
unlink(raw_bytes_tmpfile);
521520
BPLOG(ERROR) << "Failed to call objdump.";
522521
return false;

0 commit comments

Comments
 (0)