Merge pull request #124 from odrling/vlc-is-available-error

vlc: catch errors when instanciating vlc in is_available

Author: Neraste

src/dakara_player/media_player/vlc.py

@@ -90,7 +90,11 @@ def is_available():
         Returns:
             bool: `True` if VLC is useable.
         """
-        return vlc is not None and vlc.Instance() is not None
+        try:
+            return vlc is not None and vlc.Instance() is not None
+        except NameError:
+            logger.exception("Failed to start VLC.")
+            return False
 
     def init_player(self, config, tempdir):
         """Initialize the objects of VLC.

tests/unit/test_media_player_vlc.py

@@ -210,6 +210,12 @@ def test_set_vlc_callback(self):
                 vlc.EventType.MediaPlayerEndReached, callback
             )
 
+    @skipIf(vlc is None, "VLC not installed")
+    def test_vlc_unavailable(self):
+        """Test that is_available returns False when vlc.Instance raises a NameError."""
+        with patch.object(vlc, "Instance", side_effect=NameError()):
+            self.assertFalse(MediaPlayerVlc.is_available())
+
     @patch("dakara_player.media_player.vlc.libvlc_get_version")
     def test_get_version_long_4_digits(self, mocked_libvlc_get_version):
         """Test to get the VLC version when it is long and contains 4 digits."""