succeeded.log should come from a temporary directory and not the working directory

[adamnovak]

The code to make succeeded.log in the job store on completion makes that file in the working directory of the leader, and then deletes it.

toil/src/toil/leader.py

Lines 299 to 305 in 82c787c

	logName = 'failed.log' if fail else 'succeeded.log'
	localLog = os.path.join(os.getcwd(), logName)
	open(localLog, 'w').close()
	self.jobStore.import_file('file://' + localLog, logName, hardlink=True)
	if os.path.exists(localLog): # Bandaid for Jenkins tests failing stochastically and unexplainably.
	os.remove(localLog)

This is going to race on the delete if multiple Toil workflows are running at once (hence the note about Jenkins test failures), and is generally astonishing behavior. What if the user had important data in a file named succeeded.log?

If we need a file with that name outside the job store to put into it, we should make a temporary directory to hold it.

┆Issue is synchronized with this Jira Story
┆Issue Number: TOIL-1642