✨ feat: enable INP subparts collection by default (#4371)

Co-authored-by: hugo.garridoysaez <hugo.garridoysaez@datadoghq.com>

Author: HugoGarrido

packages/core/src/tools/experimentalFeatures.ts

@@ -22,7 +22,6 @@ export enum ExperimentalFeature {
   START_STOP_RESOURCE = 'start_stop_resource',
   USE_CHANGE_RECORDS = 'use_change_records',
   USE_INCREMENTAL_CHANGE_RECORDS = 'use_incremental_change_records',
-  INP_SUBPARTS = 'inp_subparts',
   TOO_MANY_REQUESTS_INVESTIGATION = 'too_many_requests_investigation',
   COMPOSED_PATH_SELECTOR = 'composed_path_selector',
 }

packages/rum-core/src/domain/view/viewMetrics/trackInteractionToNextPaint.spec.ts

@@ -1,5 +1,5 @@
 import type { Duration, RelativeTime } from '@datadog/browser-core'
-import { elapsed, relativeNow, ExperimentalFeature, addExperimentalFeatures } from '@datadog/browser-core'
+import { elapsed, relativeNow } from '@datadog/browser-core'
 import { registerCleanupTask } from '@datadog/browser-core/test'
 import {
   appendElement,
@@ -106,7 +106,7 @@ describe('trackInteractionToNextPaint', () => {
       value: 100 as Duration,
       targetSelector: undefined,
       time: 1 as RelativeTime,
-      subParts: undefined,
+      subParts: { inputDelay: 1099 as Duration, processingDuration: 0 as Duration, presentationDelay: 0 as Duration },
     })
   })
 
@@ -122,7 +122,11 @@ describe('trackInteractionToNextPaint', () => {
       value: MAX_INP_VALUE,
       targetSelector: undefined,
       time: 1 as RelativeTime,
-      subParts: undefined,
+      subParts: {
+        inputDelay: 1099 as Duration,
+        processingDuration: 100 as Duration,
+        presentationDelay: (MAX_INP_VALUE - 1199) as Duration,
+      },
     })
   })
 
@@ -139,7 +143,7 @@ describe('trackInteractionToNextPaint', () => {
       value: 98 as Duration,
       targetSelector: undefined,
       time: 98 as RelativeTime,
-      subParts: undefined,
+      subParts: { inputDelay: 1004 as Duration, processingDuration: 0 as Duration, presentationDelay: 0 as Duration },
     })
   })
 
@@ -161,7 +165,7 @@ describe('trackInteractionToNextPaint', () => {
       value: 40 as Duration,
       targetSelector: undefined,
       time: 1 as RelativeTime,
-      subParts: undefined,
+      subParts: { inputDelay: 1099 as Duration, processingDuration: 0 as Duration, presentationDelay: 0 as Duration },
     })
   })
 
@@ -179,7 +183,7 @@ describe('trackInteractionToNextPaint', () => {
       value: 100 as Duration,
       targetSelector: undefined,
       time: 100 as RelativeTime,
-      subParts: undefined,
+      subParts: { inputDelay: 1099 as Duration, processingDuration: 0 as Duration, presentationDelay: 0 as Duration },
     })
   })
 
@@ -272,10 +276,6 @@ describe('trackInteractionToNextPaint', () => {
   })
 
   describe('INP subparts', () => {
-    beforeEach(() => {
-      addExperimentalFeatures([ExperimentalFeature.INP_SUBPARTS])
-    })
-
     it('should not include subparts when INP is 0', () => {
       startINPTracking()
       interactionCountMock.setInteractionCount(1 as Duration)

packages/rum-core/src/domain/view/viewMetrics/trackInteractionToNextPaint.ts

@@ -1,5 +1,5 @@
 import type { Duration, RelativeTime } from '@datadog/browser-core'
-import { elapsed, ExperimentalFeature, isExperimentalFeatureEnabled, noop, ONE_MINUTE } from '@datadog/browser-core'
+import { elapsed, noop, ONE_MINUTE } from '@datadog/browser-core'
 import type { RumFirstInputTiming, RumPerformanceEventTiming } from '../../../browser/performanceObservable'
 import {
   createPerformanceObservable,
@@ -70,9 +70,7 @@ export function trackInteractionToNextPaint(
 
   const { getViewInteractionCount, stopViewInteractionCount } = trackViewInteractionCount(viewLoadingType)
   const longestInteractions = trackLongestInteractions(getViewInteractionCount)
-  const subPartsTracker = isExperimentalFeatureEnabled(ExperimentalFeature.INP_SUBPARTS)
-    ? createSubPartsTracker(longestInteractions)
-    : null
+  const subPartsTracker = createSubPartsTracker(longestInteractions)
   const firstInputSubscription = createPerformanceObservable(configuration, {
     type: RumPerformanceEntryType.FIRST_INPUT,
     buffered: true,
@@ -94,10 +92,10 @@ export function trackInteractionToNextPaint(
         entry.startTime <= viewEnd
       ) {
         longestInteractions.process(entry)
-        subPartsTracker?.process(entry)
+        subPartsTracker.process(entry)
       }
     }
-    subPartsTracker?.pruneUntracked()
+    subPartsTracker.pruneUntracked()
     const candidate = longestInteractions.estimateP98Interaction()
     if (candidate) {
       updateCurrentInp(candidate)
@@ -121,9 +119,7 @@ export function trackInteractionToNextPaint(
     }
     // Recomputed on every batch: the group for the p98 interaction may have been updated
     // with new min/max timing even when the p98 identity (duration, startTime) is unchanged.
-    if (subPartsTracker) {
-      currentInp.subParts = subPartsTracker.computeSubParts(candidate, sanitizeInpValue(currentInp.duration))
-    }
+    currentInp.subParts = subPartsTracker.computeSubParts(candidate, sanitizeInpValue(currentInp.duration))
   }
 
   return {
@@ -150,7 +146,7 @@ export function trackInteractionToNextPaint(
     stop: () => {
       eventSubscription.unsubscribe()
       firstInputSubscription.unsubscribe()
-      subPartsTracker?.stop()
+      subPartsTracker.stop()
     },
   }
 }

packages/rum-core/src/rumEvent.types.ts

@@ -141,6 +141,10 @@ export type RumActionEvent = CommonProperties &
            * CSS selector path of the target element
            */
           readonly selector?: string
+          /**
+           * Selector data based on the click event composed path
+           */
+          readonly composed_path_selector?: string
           /**
            * Width of the target element (in pixels)
            */
@@ -499,6 +503,16 @@ export type RumErrorEvent = CommonProperties &
     readonly feature_flags?: {
       [k: string]: unknown
     }
+    /**
+     * Internal properties
+     */
+    readonly _dd?: {
+      /**
+       * Profiling context
+       */
+      profiling?: ProfilingInternalContextSchema
+      [k: string]: unknown
+    }
     [k: string]: unknown
   }
 /**
@@ -1115,6 +1129,16 @@ export type RumVitalEventCommonProperties = CommonProperties &
       readonly description?: string
       [k: string]: unknown
     }
+    /**
+     * Internal properties
+     */
+    readonly _dd?: {
+      /**
+       * Profiling context
+       */
+      profiling?: ProfilingInternalContextSchema
+      [k: string]: unknown
+    }
     [k: string]: unknown
   }
 /**
@@ -1278,6 +1302,16 @@ export interface CommonProperties {
     readonly name?: string
     [k: string]: unknown
   }
+  /**
+   * Tab properties
+   */
+  readonly tab?: {
+    /**
+     * UUID of the browser tab
+     */
+    readonly id: string
+    [k: string]: unknown
+  }
   /**
    * Device connectivity properties
    */
@@ -1869,7 +1903,7 @@ export interface ViewProperties {
       /**
        * Number of frustrations that occurred on the view
        */
-      readonly count?: number
+      readonly count: number
       [k: string]: unknown
     }
     /**
@@ -2107,7 +2141,7 @@ export interface ViewPerformanceData {
       /**
        * Event handler execution time
        */
-      readonly processing_time: number
+      readonly processing_duration: number
       /**
        * Rendering time happening after processing
        */