Commit a325207
authored
### What does this PR do?
Replace `github.com/goccy/go-yaml` with `go.yaml.in/yaml/v3` in the 3 test files that use it, and drop the now-unused dependency from `go.mod`.
### Motivation
Finish removing one of our many YAML dependencies, therefore completing:
- #46070.
`goccy/go-yaml`'s main [stated rationale](https://github.com/goccy/go-yaml#why-a-new-library) for existing was that `go-yaml/yaml` was unmaintained and offered no AST-level access for reversible transformations.
Both are addressed today: `go.yaml.in/yaml` is the actively maintained fork, and its `yaml.Node` type supports the same tag, comment, and style preserving round-trip that `scanner_test.go` needed `goccy`'s `ast` and `token` packages for.
### Additional Notes
As [spotted by Codex](#55582 (comment)), regenerating `testdata/symbols.yaml` was unavoidable because `go.yaml.in/yaml/v3`'s encoder has no public option to reproduce `goccy`'s exact output: there is no way to add artificial indentation to a root-level sequence, and its scalar quoting is more canonical than `goccy'`s, only quoting where the YAML spec actually requires it.
Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
1 parent c35c49a commit a325207
8 files changed
Lines changed: 793 additions & 827 deletions
File tree
- deps
- pkg/dyninst
- gosymname
- testdata
- procsubscribe/procscan
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
161 | | - | |
162 | 161 | | |
163 | 162 | | |
164 | 163 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
280 | 280 | | |
281 | 281 | | |
282 | 282 | | |
283 | | - | |
284 | 283 | | |
285 | 284 | | |
286 | 285 | | |
| |||
720 | 719 | | |
721 | 720 | | |
722 | 721 | | |
| 722 | + | |
723 | 723 | | |
724 | 724 | | |
725 | 725 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | 37 | | |
39 | 38 | | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
15 | | - | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
212 | 213 | | |
213 | 214 | | |
214 | 215 | | |
215 | | - | |
216 | | - | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
217 | 222 | | |
218 | 223 | | |
219 | 224 | | |
| |||
0 commit comments