Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/collector/corechecks/system/disk/disk_nix.go spam in newer version of agents #12676

Open
kvitaly2005 opened this issue Jul 8, 2022 · 2 comments · May be fixed by #13954
Open

pkg/collector/corechecks/system/disk/disk_nix.go spam in newer version of agents #12676

kvitaly2005 opened this issue Jul 8, 2022 · 2 comments · May be fixed by #13954

Comments

@kvitaly2005
Copy link

Output of the info page (if this is a bug)

EDT | CORE | WARN | (pkg/collector/corechecks/system/disk/disk_nix.go:68 in collectPartitionMetrics) | Unable to get disk metrics of /run/docker/netns/[id] mount point: permission denied

Describe what happened:
After upgrade to 7.32.4 logs are filled with spam from disk_nix.go messages hundreds of the same every minute

Describe what you expected:
I expect logs to be clear as in version 6.18
Adding following blacklists configuration does not help:

/etc/datadog-agent/conf.d/disk.d/conf.yaml
init_config:
instances:

  • use_mount: false
    file_system_blacklist:
    • tracefs
      mount_point_blacklist:
    • /sys/kernel/debug/tracing
    • /var/lib/docker/(containers|overlay2)/.*/(shm|merged)
    • /run/docker/netns.*

Steps to reproduce the issue:
Install 7.32.4 on Linux with Docker daemon running.

Additional environment details (Operating System, Cloud provider, etc):
Debian Linux / Docker

@bkabrda
Copy link
Contributor

bkabrda commented Jul 18, 2022

Hi 👋 thanks for opening the issue. The log line you provided seems to suggest that you're using datadog-iot-agent instead of datadog-agent (the simplified Go version of the check is running instead of the full Python version). Is this correct and intentional?

In between 6.18 and 7.32 we renamed the *_blacklist arguments to *_exclude, so the configuration value you're using will not work in 7.32.4. Now, the way to fix this is slightly different for Python and Go versions of the check.

  • For the regular Python version of the check in Agent 7.32.4, as documented, you should use mount_point_exclude instead of mount_point_blacklist.
  • Assuming you want to continue using the Go version of the check, in 7.32.x you should use excluded_mountpoint_re, which accepts only a single string value as a regexp (so to transform what you have, you would have to use something like <first_exclude>|<second_exclude>|<third_exclude>).

Let me know if this helps.

@tristanpemble
Copy link

tristanpemble commented Oct 20, 2022

the config values excluded_filesystems and excluded_disks are simply not being parsed, I submitted a fix in #13954

@tristanpemble tristanpemble linked a pull request Oct 20, 2022 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants