Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] sysctl event #34482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CWS] sysctl event #34482

wants to merge 1 commit into from

Conversation

Gui774ume
Copy link
Contributor

@Gui774ume Gui774ume commented Feb 26, 2025

What does this PR do?

This PR introduces the sysctl event type by leveraging BPF_PROG_TYPE_CGROUP_SYSCTL programs. New rules can be written on the sysctl event type, so that you can capture changes to kernel configuration parameters.

For example: sysctl.action == SYSCTL_WRITE && sysctl.name == "kernel.yama.ptrace_scope" && sysctl.new_value="0" monitors when changes are made to the Yama LSM configuration, and more specifically when its restrictions on the ptrace scope is disabled.

Motivation

This new event type provides visibility into changes in some kernel configurations that are relevant for security use cases.

Describe how you validated your changes

CI tests will be added to test the changes.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 26, 2025

Uncompressed package size comparison

Comparison with ancestor 7c2c93d3cb7406f36d91c1ff9e2baebafe6e50c5

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.16MB ⚠️ 827.82MB 827.66MB 0.50MB
datadog-agent-x86_64-suse 0.16MB ⚠️ 827.82MB 827.66MB 0.50MB
datadog-agent-aarch64-rpm 0.16MB ⚠️ 818.78MB 818.62MB 0.50MB
datadog-agent-amd64-deb 0.16MB ⚠️ 818.03MB 817.87MB 0.50MB
datadog-agent-arm64-deb 0.16MB ⚠️ 809.01MB 808.85MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.96MB 37.96MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 443.28MB 443.28MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.02MB 62.02MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.27MB 59.27MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.33MB 59.33MB 0.50MB

Decision

⚠️ Warning

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e5139a50-6222-4c6e-8f77-1ce6e71102d7

Baseline: 7c2c93d
Comparison: b03cf85
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.19 [-0.74, +5.13] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +1.21 [+0.33, +2.09] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.66 [+0.61, +0.72] 1 Logs
quality_gate_idle_all_features memory utilization +0.18 [+0.12, +0.24] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.79, +0.84] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.27, +0.30] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.80, +0.80] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.00 [-0.83, +0.83] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.67, +0.65] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.02 [-0.49, +0.45] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.65, +0.61] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.14 [-0.92, +0.65] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.14 [-0.92, +0.64] 1 Logs
quality_gate_idle memory utilization -0.19 [-0.23, -0.15] 1 Logs bounds checks dashboard
file_tree memory utilization -0.44 [-0.50, -0.38] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant